Skip to content

Use <iostream> instead of <iostream.h> in Example Code for PCH #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Use <iostream> instead of <iostream.h> in Example Code for PCH #1546

merged 3 commits into from
Oct 25, 2019

Conversation

TedLyngmo
Copy link
Contributor

This old header seems to have been forgotten in one of the example files (UNSTABLE.H).

This old header seems to have been forgotten in one of the example files
(UNSTABLE.H).

Signed-off-by: Ted Lyngmo <[email protected]>
@PRMerger6
Copy link
Contributor

@TedLyngmo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger6 PRMerger6 requested a review from colin-home September 5, 2019 22:04
@ktoliver ktoliver added the aq-pr-triaged Tracking label for the PR review team label Sep 6, 2019
@jborsecnik
Copy link
Contributor

I assume this is still in process. When you are done, please add a hash comment to indicate the action to take on this PR. Thanks.

@colin-home
Copy link
Contributor

@TedLyngmo
Yes, I apologize for not commenting earlier. The header update is welcome; thanks for spotting that and contributing a change. I was working on getting the example to compile, and got the code looking okay with an added using statement, but ran into trouble with the makefile. It appears to be ancient, referring to libraries and command-line options that no longer exist. I thought I'd added a comment when I made an edit, but I may have gotten distracted while looking at the makefile problem. I'll take another look soon. Until then, I want to hold off on merging this. Thanks for your patience!

@TedLyngmo
Copy link
Contributor Author

@corob-msft
No worries! Take your time. +1 on spotting the missing using statement.

@jborsecnik
I assume the hash comment link was for the MS staff?

@jborsecnik
Copy link
Contributor

Yes. I wasn't sure if corob-msft's comment meant he was done with it. Thanks.

@PRMerger12
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TedLyngmo Thanks for contributing. I'm going to adopt the change even though I haven't fixed the makefile yet, since I'm still hoping to get to that but haven't had time.

@colin-home colin-home merged commit b95c1ea into MicrosoftDocs:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants