Skip to content

Document new rule C26820 #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dmitrykobets
Copy link
Contributor

@PRMerger7
Copy link
Contributor

@dmitrykobets : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

ktoliver commented Apr 8, 2020

Hi @corob-msft - Could you work with @dmitrykobets to move this commit to the private repo and ensure that it meets all PR review quality criteria? It should pass build validation, be added to a TOC, be viewed on staging, and be PR-reviewed before being merged in the private repo. Thanks.

@PRMerger14
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitrykobets
Thanks, Dmitry, this looks great! I rearranged the content slightly, and simplified some sentences to make our grammar checker happy. Take a look and verify that I haven't changed anything important in the article. If it's okay, let me know and I'll merge it. If not, feel free to make an edit pass. Thanks!

@colin-home
Copy link
Contributor

... and I'll move it to the private repo. I missed Kristine's comment before starting my edits.

@colin-home
Copy link
Contributor

Closing in favor of the private repo version Document new rule C26820 #2798.

@colin-home colin-home closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants