Skip to content

There are no short integer literals #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

yecril71pl
Copy link
Contributor

I replaced literals for short integer types with literals for medium integer types because there are no such literals (0S is not a valid short integer).

I replaced literals for _short_ integer types with literals for _medium_ integer types because there are no such literals (`0S` is not a valid short integer).
@PRMerger10
Copy link
Contributor

@yecril71pl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Swap medium for long long, and add binary as an option.
@PRMerger10
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yecril71pl
Thanks for the update. I don't know where the short part came from, unless by some analogy with float. I swapped "long long" in for "medium" since I'd rather not explain what the word "medium" means when it isn't used anywhere else.

@colin-home colin-home merged commit aed7560 into MicrosoftDocs:master Oct 1, 2020
@yecril71pl yecril71pl deleted the patch-1 branch October 1, 2020 20:24
@yecril71pl
Copy link
Contributor Author

@yecril71pl
Thanks for the update. I don't know where the short part came from, unless by some analogy with float. I swapped "long long" in for "medium" since I'd rather not explain what the word "medium" means when it isn't used anywhere else.

I think it goes back to the time of 16–bit CPUs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants