Skip to content

Update cmake-linux-configure.md #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

FrankAtHexagon
Copy link
Contributor

Added information about change from Unix Makefiles so that example JSON is less confusing.

Added information about change from Unix Makefiles so that example JSON is less confusing.
@PRMerger12
Copy link
Contributor

@FrankAtHexagon : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TylerMSFT
Copy link
Collaborator

@FrankAtHexagon , thank you for taking an interest in updating the docs. I'm interested in your thinking behind adding "as opposed to Unix Makefiles". I'm curious why you think that emphasis needs to be added. The text right now says what you need, without introducing a secondary concept that may make some readers wonder why it is being called out.

@FrankAtHexagon
Copy link
Contributor Author

The reason I thought this was necessary is because the text above the example says this:

The default Linux-Debug configuration in Visual Studio 2019 version 16.1, and later, looks like this...

And then provides an example with 'Unix Makefiles.' However, the text right after the example says this:

In Visual Studio 2019 version 16.6 or later, Ninja is the default generator for configurations targeting a remote system or WSL.

So I thought it was confusing which generator would typically be the default, until I read the blog post.

@TylerMSFT
Copy link
Collaborator

@FrankAtHexagon , great justification. Thank you for explaining. I'll get your change merged today. I really appreciate you taking the time to improve our docs.

@TylerMSFT TylerMSFT merged commit 9be23d1 into MicrosoftDocs:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants