Skip to content

Update wcstombs-s-wcstombs-s-l.md #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Update wcstombs-s-wcstombs-s-l.md #3416

merged 2 commits into from
Oct 1, 2021

Conversation

mohammad-ghasemi-dev
Copy link
Contributor

count parameter should reserve one place for the terminating null character.

count should reserve one place for terminating null character.
@PRMerger8
Copy link
Contributor

@mohammad-ghasemi-2549 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammad-ghasemi-2549 , thank you for your interest in the docs. At first I wasn't clear about your change because The docs call out that the count parameter specifically does not account for the NULL character. But I think what you are doing is accounting for that so that the trailing NULL doesn't land 1 past the buffer in case the text takes up the amount of room for the buffer. Yes?

@mohammad-ghasemi-dev
Copy link
Contributor Author

mohammad-ghasemi-dev commented Sep 30, 2021

yes

Add a couple other fixes since the file is being updated.
@ghost
Copy link

ghost commented Sep 30, 2021

CLA assistant check
All CLA requirements met.

@TylerMSFT
Copy link
Collaborator

#sign-off
We are running into this problem again where the contributor license agreement appears to have been signed but the status is still pending.

@TylerMSFT
Copy link
Collaborator

@mohammad-ghasemi-2549, could you try signing the CLA again above? I'd like to get your change merged.

@PRMerger16
Copy link
Contributor

@TylerMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16 PRMerger16 requested a review from TylerMSFT October 1, 2021 02:39
@ShannonLeavitt
Copy link
Contributor

The CLA signing problem appears to be resolved. Merging now.

@ShannonLeavitt ShannonLeavitt merged commit 2917732 into MicrosoftDocs:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants