Skip to content

Update latest-supported-vc-redist.md #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

Update latest-supported-vc-redist.md #3876

merged 1 commit into from
May 6, 2022

Conversation

MatinSasan
Copy link
Contributor

In the line 35, at the very end, removed an extra dot.

In the line 35, at the very end removed an extra dot.
@PRMerger12
Copy link
Contributor

@MatinSasan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented May 6, 2022

Looks good; thanks, @MatinSasan

@Court72 Court72 merged commit a04010b into MicrosoftDocs:main May 6, 2022
@MatinSasan MatinSasan deleted the patch-1 branch May 6, 2022 18:42
@MatinSasan MatinSasan restored the patch-1 branch May 6, 2022 18:42
@MatinSasan MatinSasan deleted the patch-1 branch May 6, 2022 18:42
@MatinSasan
Copy link
Contributor Author

Hello, @Court72
Recently I noticed I'm getting "empty" contributions in the contribution graph of my profile.
I contacted Git Support fearing it might be a bug, and they replied that I got included as a co-author here

I'd like to be excluded from the list. Because my contribution was so minor and I don't like to be co-credited anymore with something I have nothing to do.
Thank you for your attention.

@Court72
Copy link
Contributor

Court72 commented May 26, 2022

Hi @MatinSasan

I don't know how to change that list. I'd suggest contacting Git Support again to see if they can remove your name if you prefer.

Thanks!

@MatinSasan
Copy link
Contributor Author

Hello @corob-msft
Could you possibly please remove my name form the co-author list. The reason and the links are provided in my comment above.
Suggested by your colleague, I'll contact Git Support nevertheless.
Thank you both.

@colin-home
Copy link
Contributor

@MatinSasan
I'm sorry your contribution has led to difficulties. That's certainly not the experience we'd like contributors to have. From what I've read so far, apparently, there isn't an easy way to remove a commit's author from the history. I'm not a Git expert, so I've been reading up on deleting commits and rewriting history, and the consequences of rewriting history in a public repo are a bit scary, involving changing three weeks' worth of subsequent commits. Given our publishing automation, some Stack Overflow suggestions such as deleting and recreating the whole repo are impractical.

I'm not sure I understand what's going on with the "empty" contributions, either. Your support ticket appears to be private to you, so I can't see it. On your public page, it says you contributed to MicrosoftDocs/cpp-docs with 14 commits, but when I click on the 14 commits link, it only shows one.

What is your experience here? Did you get 14 email notifications about commits? If you did, when did they arrive? All at once, or spread out across days? I'm mostly curious what's causing these spurious commits to appear, if it was a one-time issue, or if it's going to continue. And I don't know if it's a Git issue or a GitHub issue. If it's the latter, the support option is probably the only way to deal with it.

If the issue is ongoing and caused by changes to the one affected file, I have another option, which is to delete the file, update the repo, and then recreate it. That should divorce the file from its history, so you'd stop seeing update notifications for changes to it. I don't think that's the source of the problem, but it's less fraught than rewriting history for the repo as a whole.

@MatinSasan
Copy link
Contributor Author

@corob-msft
First of all, thanks for your thorough explanation and conscientious efforts.
Oh, thanks for the feedback, I didn't know the GS ticket is private. I didn't see any option for making it public/private.
Back then GS reached out to me and told me to contact you first then them if it didn't work out.
And yesterday I wrote to them again, still haven't heard any word from them so far.

I made PRs to nodejs and axios before, and they didn't have this problem, probably they must have been aware of such a "feature". At least, by bringing it up to the attention of your team that helped to clarify that wasn't the original intention, and that should also help to pave the way toward preventing any future issue with other future contributors, hopefully.

To give feedback:

  • no, I didn't receive any email notification for any of them.
  • they appear the moment they are committed, in my contribution graph, silently.
  • when I click on each "empty" commit link, the commit page shows No commits found for "MatinSasan".
  • As far as I know it seems like a Github "feature".
  • That file I contributed to, Update latest-supported-vc-redist.md, is showing that only I made the last change there, so I'm not sure deleting that would lead to decoupling co-authors, but I'm not a github/git expert.

Such "empty" commits make me feel like a "imposter" in my contribution graph, I made such a negligible contribution. I'm not even into C++, just curious about the docs, as I was reading Microsoft docs at that time where each is addressing each other from link to link.

I will link your comment to that Git Support ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants