Skip to content

Add note about supported windows versions to <chrono> #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2022
Merged

Add note about supported windows versions to <chrono> #3906

merged 1 commit into from
May 20, 2022

Conversation

barcharcraz
Copy link
Contributor

Some features of chrono are not supported when running on older versions of windows, but that's only documented in our github changelogs and is very, very easy to miss.

This clarifies the situation directly in the toplevel chrono documentation.

It may also be good to add a note or link back from the individual time-zone functions.

@PRMerger17
Copy link
Contributor

@barcharcraz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented May 18, 2022

@TylerMSFT

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"

@PRMerger16 PRMerger16 added the aq-pr-triaged Tracking label for the PR review team label May 18, 2022
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Charlie!

@TylerMSFT
Copy link
Collaborator

#sign-off

@jborsecnik jborsecnik merged commit 97ec420 into MicrosoftDocs:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants