Skip to content

Visual C++ 17.0 has unlimited string literals #4063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jul 24, 2022

I believe this was changed while fixing https://developercommunity.visualstudio.com/t/1437715
@cdacamar knows for sure.

@PRMerger7
Copy link
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld33
Copy link

opbld33 commented Jul 24, 2022

Docs Build status updates of commit a0b62f1:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/string-and-character-literals-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Jul 25, 2022

@corob-msft

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@PRMerger7 PRMerger7 added the aq-pr-triaged Tracking label for the PR review team label Jul 25, 2022
@cdacamar
Copy link
Contributor

cdacamar commented Aug 5, 2022

There are two independent feedback issues we fixed to address the string size limitation:

https://developercommunity.visualstudio.com/t/__FUNCTIONW__-cannot-handle-long-names-a/1425758
https://developercommunity.visualstudio.com/t/Long-literal-char-arrays-are-not-interpr/1374615

In both cases, after 17.0, the compiler has no limitation on string length emission. The only remaining limitation is in how large of a string literal the preprocessor can handle--which is not currently documented.

@PRMerger4
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsb4000 Thanks for being patient; this change is good to go.

@opbld31
Copy link

opbld31 commented Aug 5, 2022

Docs Build status updates of commit 1020b7b:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/string-and-character-literals-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Aug 5, 2022

Docs Build status updates of commit 1020b7b:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/string-and-character-literals-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@fsb4000
Copy link
Contributor Author

fsb4000 commented Aug 5, 2022

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.