-
Notifications
You must be signed in to change notification settings - Fork 967
Visual C++ 17.0 has unlimited string literals #4063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit a0b62f1: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@corob-msft Can you review this PR? IMPORTANT: When this content is ready to merge, you must add #label:"aq-pr-triaged" |
There are two independent feedback issues we fixed to address the string size limitation: https://developercommunity.visualstudio.com/t/__FUNCTIONW__-cannot-handle-long-names-a/1425758 In both cases, after 17.0, the compiler has no limitation on string length emission. The only remaining limitation is in how large of a string literal the preprocessor can handle--which is not currently documented. |
@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsb4000 Thanks for being patient; this change is good to go.
Docs Build status updates of commit 1020b7b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 1020b7b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Great! Thanks! |
I believe this was changed while fixing https://developercommunity.visualstudio.com/t/1437715
@cdacamar knows for sure.