Skip to content

Fixed inconsistent spelling of "newline" #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

weijuwang
Copy link
Contributor

"newline" was spelled as "new-line" two out of four times in the documentation.

"newline" was spelled as "new-line" two out of four times in the document.
@prmerger-automator
Copy link
Contributor

@weijuwang : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld33
Copy link

opbld33 commented Aug 19, 2022

Docs Build status updates of commit aa9156b:

✅ Validation status: passed

File Status Preview URL Details
docs/c-language/lexical-grammar.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Aug 19, 2022

@corob-msft - Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Aug 19, 2022
Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weijuwang
Thanks for pointing out the inconsistency and proposing a fix. You have the right idea, but you've fixed the wrong targets. Ordinarily, I'd accept this PR, because the common term we use in the rest of the documentation is "newline". However, the C lexical grammar page quotes Annex A of the C17 Standard, which uses "new-line" everywhere. To be consistent, we should change the two cases of "newline" to "new-line". I'll approve and merge the PR if you make those changes. Thank you again for taking the time to make the docs better.

@prmerger-automator
Copy link
Contributor

@weijuwang : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@weijuwang
Copy link
Contributor Author

Should be fixed now. Thanks for the response!

@opbld32
Copy link

opbld32 commented Aug 20, 2022

Docs Build status updates of commit 2bc0468:

✅ Validation status: passed

File Status Preview URL Details
docs/c-language/lexical-grammar.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick turnaround, @weijuwang

@colin-home colin-home merged commit 70d2dcf into MicrosoftDocs:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants