-
Notifications
You must be signed in to change notification settings - Fork 967
Fixed inconsistent spelling of "newline" #4104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"newline" was spelled as "new-line" two out of four times in the document.
@weijuwang : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit aa9156b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@corob-msft - Can you review this PR? IMPORTANT: When this content is ready to merge, you must add #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weijuwang
Thanks for pointing out the inconsistency and proposing a fix. You have the right idea, but you've fixed the wrong targets. Ordinarily, I'd accept this PR, because the common term we use in the rest of the documentation is "newline". However, the C lexical grammar page quotes Annex A of the C17 Standard, which uses "new-line" everywhere. To be consistent, we should change the two cases of "newline" to "new-line". I'll approve and merge the PR if you make those changes. Thank you again for taking the time to make the docs better.
@weijuwang : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Should be fixed now. Thanks for the response! |
Docs Build status updates of commit 2bc0468: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the quick turnaround, @weijuwang
"newline" was spelled as "new-line" two out of four times in the documentation.