-
Notifications
You must be signed in to change notification settings - Fork 967
Small correction in getch-getwch #4167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
'key code' implies virtual key code whereas the function actually returns a scan code on the second call, added link for further clarity
@NathanIsBored13 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit 304400f:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/c-runtime-library/reference/getch-getwch.md | Details |
docs/c-runtime-library/reference/getch-getwch.md
- Line 33, Column 324: [Warning: hard-coded-locale - See documentation]
Link 'https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-6.0/aa299374(v=vs.60)?redirectedfrom=MSDN' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 33, Column 324: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-6.0/aa299374(v=vs.60)?redirectedfrom=MSDN' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
@NathanIsBored13 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit 556950b:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/c-runtime-library/reference/getch-getwch.md | Details |
docs/c-runtime-library/reference/getch-getwch.md
- Line 33, Column 324: [Warning: file-not-found - See documentation]
Invalid file link: '../../../previous-versions/visualstudio/visual-studio-6.0/aa299374(v=vs.60)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
@NathanIsBored13 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Docs Build status updates of commit c7f5522:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/c-runtime-library/reference/getch-getwch.md | Details |
docs/c-runtime-library/reference/getch-getwch.md
- Line 33, Column 324: [Warning: file-not-found - See documentation]
Invalid file link: 'previous-versions/visualstudio/visual-studio-6.0/aa299374(v=vs.60)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
sorry for the corrections, this is my first time contributing and I messed up the link format |
@NathanIsBored13, this was a good addition. You were really close - just needed a leading '/' |
'key code' implies virtual key code whereas the function actually returns a scan code on the second call, added link for further clarity