Link C4834 to C26457 #4638
Link C4834 to C26457 #4638
Conversation
C4834 recommends either using referenced value or casting to (void). However, we also have a code quality rule for [[nodiscard]] that says "assign to std::ignore" is preferred over "(void)". The documentation should link to this page, rather than recommending an approach we will also warn over.
|
@cgettys-microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 34b1d6a:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/error-messages/compiler-warnings/c4834.md | Details |
docs/error-messages/compiler-warnings/c4834.md
- Line 16, Column 243: [Warning: file-not-found - See documentation]
Invalid file link: 'code-quality/c26457.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
relative link to linked page
|
Learn Build status updates of commit 78a9543: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
#sign-off - ready to merge from my end |
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @TylerMSFT |
|
#sign-off |
C4834 recommends either using referenced value or casting to (void). However, we also have a code quality rule for [[nodiscard]] that says "assign to std::ignore" is preferred over "(void)". The documentation should link to this page, rather than recommending an approach we will also warn over.