Skip to content

Merge code blocks for C2504 #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rageking8
Copy link
Contributor

Merge both code blocks together as the second one does not have proper syntax highlighting and its slighter more terse this way. Also did some light formatting for the example and text.

@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ebfd8db:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2504.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Oct 2, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 2, 2023
@TylerMSFT
Copy link
Collaborator

@Rageking8, thank you for helping out with the docs.
This week I'm working to a deadline for some other content, so it'll be a week or so before I can look at these. Take care.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an improvement. Thank you.

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt
Copy link
Contributor

Thanks @Rageking8

@ShannonLeavitt ShannonLeavitt merged commit 059d937 into MicrosoftDocs:main Oct 20, 2023
@Rageking8 Rageking8 deleted the merge-code-blocks-for-c2504 branch November 3, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants