Skip to content

Update C2993 #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2023
Merged

Update C2993 #4747

merged 3 commits into from
Oct 23, 2023

Conversation

Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Oct 3, 2023 •
edited
Loading

Removed some old comments that make little sense today and updated the whole page to be valid with the latest info.

@prmerger-automator prmerger-automator bot requested a review from TylerMSFT October 3, 2023 13:47
@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 95dc0fb:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2993.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Rageking8
Copy link
Contributor Author

No rush for review, just wanted to pass the validations and put the PR out there first.

@Court72
Copy link
Contributor

Court72 commented Oct 3, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 3, 2023
@TylerMSFT
Update compiler-error-c2993.md
aed3da7 
Tried to make the flow easier to follow for the different errors that are emitted now vs. before.
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit aed3da7:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2993.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT
Update compiler-error-c2993.md
c1c4f60 
Couple last edits, including a couple that would be Acrolinx hits.
TylerMSFT
TylerMSFT approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rageking8, thank you for improving these examples and particularly for calling out the change in behavior and w/which version.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c1c4f60:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2993.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS Jak-MS merged commit c61c9b4 into MicrosoftDocs:main Oct 23, 2023
@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 23, 2023

merged

@Rageking8 Rageking8 deleted the update-c2993 branch November 3, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-diagnostics/tech needs-human-review ready-to-merge visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rageking8 @Court72 @TylerMSFT @Jak-MS