Skip to content

Improve __declspec(noreturn) example #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2023
Merged

Improve __declspec(noreturn) example #4806

merged 3 commits into from
Nov 9, 2023

Conversation

Rageking8
Copy link
Contributor

Fixes #4649

@prmerger-automator PRMerger Automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit a409df5:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/noreturn.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator PRMerger Automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Nov 8, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 8, 2023
@TylerMSFT
Update noreturn.md
6414c06 
Use cpub coding style. Update the name to be a little more descriptive of what it does. Minor edits.
@TylerMSFT
Update noreturn.md
5102d7d 
Preventing some Acrolinx errors that I anticipate would show up on this text.
TylerMSFT
TylerMSFT approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @Rageking8! I like your example better than what was there.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 6414c06:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/noreturn.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator PRMerger Automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 5102d7d:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/noreturn.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator PRMerger Automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS Jak-MS merged commit e6ead26 into MicrosoftDocs:main Nov 9, 2023
@Rageking8 Rageking8 deleted the improve-__declspec-noreturn-example branch November 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-language/tech needs-human-review ready-to-merge visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad __declspec(noreturn) example
4 participants
@Rageking8 @Court72 @TylerMSFT @Jak-MS