Skip to content

Update clang-tidy.md #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Update clang-tidy.md #4948

merged 7 commits into from
Feb 28, 2024

Conversation

sinemakinci1
Copy link
Contributor

Adding support for CMake Presets

Adding support for CMake Presets
Copy link
Contributor

@sinemakinci1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 0c23813:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Feb 21, 2024

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 21, 2024
addressing some feedback
Copy link
Contributor

Learn Build status updates of commit ea7939d:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@sinemakinci1
Copy link
Contributor Author

@TylerMSFT can you take a look at the updates now?

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sinem! Left a couple comments.

Copy link
Contributor

@sinemakinci1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sinemakinci1
Copy link
Contributor Author

@TylerMSFT updated, thanks for your additional review!

Copy link
Contributor

Learn Build status updates of commit a52b023:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 01ec199:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I missed a tagging issue for the code blocks.

Copy link
Contributor

Learn Build status updates of commit 6de2ecf:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sinem!

@Jak-MS Jak-MS merged commit 2bf26aa into MicrosoftDocs:main Feb 28, 2024
Copy link
Contributor

Learn Build status updates of commit d90f8ad:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 474bf33:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants