-
Notifications
You must be signed in to change notification settings - Fork 967
Fixing a dead link to the vcpkg toolchain file page #5065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Suisse00 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 9a66091:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/c-language/index.yml | Details | ||
docs/code-quality/index.yml | Details | ||
docs/cpp/index.yml | Details | ||
docs/intrinsics/index.yml | Details | ||
docs/build/customize-cmake-settings.md | ✅Succeeded |
docs/c-language/index.yml
- Line 6, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
docs/code-quality/index.yml
- Line 7, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
docs/cpp/index.yml
- Line 6, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
docs/intrinsics/index.yml
- Line 7, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Trying a close/reopen to clear the warnings. |
Learn Build status updates of commit 9a66091:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/c-language/index.yml | Details | ||
docs/code-quality/index.yml | Details | ||
docs/cpp/index.yml | Details | ||
docs/intrinsics/index.yml | Details | ||
docs/build/customize-cmake-settings.md | ✅Succeeded |
docs/c-language/index.yml
- Line 6, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
docs/code-quality/index.yml
- Line 7, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
docs/cpp/index.yml
- Line 6, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
docs/intrinsics/index.yml
- Line 7, Column 3: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Can you review the proposed changes? Note that the validation warnings must be resolved before merging. Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@Suisse00 , thank you for making these changes. Before we can merge, can you fix the warnings? |
@Suissee00, actually, I'll just do it and close this PR. I'll open another with all the metadata fixes. |
My pull request #5620 makes your change, adds a code escape fix, and takes care of the index.yml warnings. |
Hi,
While reading https://learn.microsoft.com/en-us/cpp/build/customize-cmake-settings?view=msvc-170#cmake-toolchain-file you refer to
vcpkg toolchain file
with this deadlink https://github.com/microsoft/vcpkg/blob/master/docs/examples/installing-and-using-packages.md#cmake.They moved the repository from https://github.com/microsoft/vcpkg to https://github.com/microsoft/vcpkg-docs - so the new url is https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/installing-and-using-packages.md
There could be other dead link to that repository, but at least here's one fixed.