Skip to content

Fixing a dead link to the vcpkg toolchain file page #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Suisse00
Copy link

Copy link
Contributor

@Suisse00 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 9a66091:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/c-language/index.yml ⚠️Warning Details
docs/code-quality/index.yml ⚠️Warning Details
docs/cpp/index.yml ⚠️Warning Details
docs/intrinsics/index.yml ⚠️Warning Details
docs/build/customize-cmake-settings.md ✅Succeeded

docs/c-language/index.yml

  • Line 6, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

docs/code-quality/index.yml

  • Line 7, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

docs/cpp/index.yml

  • Line 6, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

docs/intrinsics/index.yml

  • Line 7, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 10, 2024

Trying a close/reopen to clear the warnings.

@Court72 Court72 closed this Jul 10, 2024
@Court72 Court72 reopened this Jul 10, 2024
Copy link
Contributor

Learn Build status updates of commit 9a66091:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/c-language/index.yml ⚠️Warning Details
docs/code-quality/index.yml ⚠️Warning Details
docs/cpp/index.yml ⚠️Warning Details
docs/intrinsics/index.yml ⚠️Warning Details
docs/build/customize-cmake-settings.md ✅Succeeded

docs/c-language/index.yml

  • Line 6, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

docs/code-quality/index.yml

  • Line 7, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

docs/cpp/index.yml

  • Line 6, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

docs/intrinsics/index.yml

  • Line 7, Column 3: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 10, 2024

@TylerMSFT

Can you review the proposed changes? Note that the validation warnings must be resolved before merging.

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jul 10, 2024
@TylerMSFT
Copy link
Collaborator

TylerMSFT commented Jul 10, 2024

@Suisse00 , thank you for making these changes. Before we can merge, can you fix the warnings?
Or, if you'd rather, go ahead and close this PR and I'll do it from my side. Either way is fine.

@TylerMSFT
Copy link
Collaborator

@Suissee00, actually, I'll just do it and close this PR. I'll open another with all the metadata fixes.
Take care.

@TylerMSFT TylerMSFT closed this Jul 10, 2024
@TylerMSFT
Copy link
Collaborator

My pull request #5620 makes your change, adds a code escape fix, and takes care of the index.yml warnings.
Thank you for pointing out the link problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants