Skip to content

Fix the description of the _MBC_ILLEGAL return value, especially so in the case type == _MBC_LEAD. #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

WilliamCushing
Copy link
Contributor

Add english descriptions of the conditions that results in illegality, and spell out the value ranges in positive fashion rather than negative fashion based on the values shown in the other rows.

Note that the table does not demonstrate locale-sensitivity or codepage-sensitivity; are the given example values the ones used for codepage 932 (japanese kanji)? Does locale really effect _mbbtype?

Copy link
Contributor

@WilliamCushing : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 7a3dba4:

✅ Validation status: passed

File Status Preview URL Details
docs/c-runtime-library/reference/mbbtype-mbbtype-l.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ShannonLeavitt
Copy link
Contributor

@TylerMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Aug 16, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice improvement over the inverted ranges, and the broken range

@TylerMSFT
Copy link
Collaborator

#sign-off
I'll add addressing your question to my backlog. It'll be a while before I can get to it.

@TylerMSFT TylerMSFT merged commit eda9963 into MicrosoftDocs:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants