Skip to content

P0859R0 was implemented in VS 2022 17.1 #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Sep 14, 2024

Could you recheck the change please? @cdacamar told me that the feature is implemented if I understood correctly.
If not then I will change the same line at https://en.cppreference.com/w/cpp/compiler_support/20 to partial.

Copy link
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 6361e94:

✅ Validation status: passed

File Status Preview URL Details
docs/overview/visual-cpp-language-conformance.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@fsb4000
Copy link
Contributor Author

fsb4000 commented Sep 15, 2024

@CaseyCarter wrote: "It looks like the work item (VSO-977249) has been "In Progress" since 2021. From the discussion, I get the impression that it's mostly complete. Maybe C++14 support (this was a DR) is not all there? It's not clear to me. For cppreference purposes, I think the fact that we don't define the feature-test macro (https://godbolt.org/z/xcbrv1964) decidedly means we should not claim support."

And I changed the cppreference line to partial. But @TylerMSFT , could you recheck the current status of P0859R0 in MSVC?

@cdacamar
Copy link
Contributor

And I changed the cppreference line to partial. But @TylerMSFT , could you recheck the current status of P0859R0 in MSVC?

Could you please revert that? The compiler implementation has been in place since 2021 and supported by (8e97889d258fefe25a9357e1852167832e4b6c37. The feature test macro was never part of the original DR: P0859R0 and appeared to be added editorially later.

Speaking to why the work item is not complete: internally we used these items known as "UserStory" items to track all of the C++20 work, many of them were not marked as completed due to the automated system (Azure DevOps) being incapable of moving UserStory items -> complete, so many of them are still marked as "In Progress" due to them not being user-visible.

@fsb4000
Copy link
Contributor Author

fsb4000 commented Sep 16, 2024

Could you please revert that?

Sure, I'll do.

@Court72
Copy link
Contributor

Court72 commented Sep 16, 2024

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Sep 16, 2024
@TylerMSFT
Copy link
Collaborator

My take from the discussion above is that this change to the docs shouldn't go in. Correct?

@CaseyCarter
Copy link
Contributor

My take from the discussion above is that this change to the docs shouldn't go in. Correct?

Yes. There was confusion that I contributed to which Cameron corrected. The change is good.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit 4efa559 into MicrosoftDocs:main Sep 17, 2024
2 checks passed
@fsb4000 fsb4000 deleted the patch-1 branch September 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants