Skip to content

Update how-to-create-and-use-shared-ptr-instances.md #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

IceyPillow
Copy link
Contributor

The old description about shared_ptr is wrong.

If we pass a raw ptr to a callee func, and use it to create a new shared_ptr, it's dangerous because callee will delete the resource where raw ptr pointed to.

Please accept this revision.
image

Adjust some wrong description about shared_ptr
Copy link
Contributor

@Nowhere6 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8f4542d:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/how-to-create-and-use-shared-ptr-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Dec 2, 2024

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Dec 2, 2024
Copy link
Contributor

Learn Build status updates of commit af22544:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/how-to-create-and-use-shared-ptr-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding clarity around this scenario.

Copy link
Contributor

Learn Build status updates of commit e524ab0:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/how-to-create-and-use-shared-ptr-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit c9a7a4a into MicrosoftDocs:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants