Skip to content

Fix MASM dot-code and dot-data to indicate they also work on x64 #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

nir9
Copy link
Contributor

@nir9 nir9 commented Dec 5, 2024

Problem: Current documentation of .DATA and .CODE is confusing since it starts with a sentence that says 32 bit only which can lead to a misunderstanding that it is not supported in x64

Copy link
Contributor

@nir9 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 807f208:

✅ Validation status: passed

File Status Preview URL Details
docs/assembler/masm/dot-code.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@nir9 nir9 changed the title Fix MASM dot-code to indicate it also works on x64 Fix MASM dot-code and dot-data to indicate they also work on x64 Dec 5, 2024
Copy link
Contributor

Learn Build status updates of commit 07887f4:

✅ Validation status: passed

File Status Preview URL Details
docs/assembler/masm/dot-code.md ✅Succeeded
docs/assembler/masm/dot-data.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Dec 5, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the clarity.

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit a1acd66 into MicrosoftDocs:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants