Skip to content

C26135: Update comments to use correct annotation #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Jan 7, 2025

The lock is the critical section, not the pointer to it.

Annotation uses p->cs

By the way, the contributing guide is outdated as it continues to make references to Issues, even though this repository has them disabled. What is the new way to start discussions as listed in the do's/don'ts section?

Copy link
Contributor

@winstliu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 2b20c4c:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/c26135.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Jan 7, 2025

@TylerMSFT
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jan 7, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winstliu - thank you for fixing this.

even though this repository has them disabled. What is the new way to start discussions as listed in the do's/don'ts section?
Some repos still use GitHub issues, though the C++ docs repo doesn't. To provide feedback on the C++ docs, please use the feedback button in the top right of the help topic page. That will generate a work item that shows up in my queue.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS Jak-MS merged commit ab7377b into MicrosoftDocs:main Jan 10, 2025
2 checks passed
@winstliu winstliu deleted the 26135-correct-warning-annotation-comment branch January 10, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants