Skip to content

Update check-stack.md #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update check-stack.md #5171

wants to merge 1 commit into from

Conversation

RatinCN
Copy link
Contributor

@RatinCN RatinCN commented Feb 3, 2025

#pragma check_stack( ) and #pragma check_stack will make stack checking reverts to the behavior specified on the command line, so if /Gs presents in command line, stack checking is turn on, otherwise it's turn off.

Copy link
Contributor

@RatinCN : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 3b39ca5:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/check-stack.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Feb 3, 2025

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 3, 2025
@TylerMSFT
Copy link
Collaborator

TylerMSFT commented Feb 7, 2025

Hi @RatinCN , thank you for taking the time to point this out. I spent time looking at the assembly for different combinations of this flag, and talked to the dev team about it, and I'm going to close this PR because the behavior doesn't line up. In fact, for clarity's sake, one shouldn't use this pragma without arguments.
I've opened PR#5769 to update this topic. Thanks for raising this. It was interesting to dig through the generated code for the various combinations of this flag.

@TylerMSFT TylerMSFT closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants