Skip to content

Update asan.md to remove PGO from supported optimization levels #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

zacklj89
Copy link
Contributor

@zacklj89 zacklj89 commented Feb 7, 2025

PGO is incompatible with /fsanitize=address. When you try, you are met with

C5084: Profile-guided optimization is not supported alongside Address Sanitizer. Address Sanitizer should not be used in production

Copy link
Contributor

@zacklj89 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit d7c307a:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/asan.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit e03381a:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/asan.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Feb 7, 2025

@TylerMSFT

Thanks for approving these changes!

When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 7, 2025
@TylerMSFT
Copy link
Collaborator

I was waiting for the author to sign off but I think I can do it in this case.
#sign-off

@Court72 Court72 merged commit 5a00408 into MicrosoftDocs:main Feb 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants