Update popcnt16-popcnt-popcnt64.md #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "16-, 32-, or 64-byte" is an obvious typo. * "The size of the value that the `popcnt` instruction returns is the same as the size of its argument." is a clear case of "parameter" vs. "argument" confusion. The size / type of the return value does not change to reflect the size/type of the expression passed to the function at a callsite - this sentence means "parameter." (Although honestly, this sentence adds little value - we should consider striking it.)
|
@CaseyCarter : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
mikeblome
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Thanks @CaseyCarter! I went ahead and deleted the sentence.
|
#sign-off |
|
@mikeblome: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
popcntinstruction returns is the same as the size of its argument." is a clear case of "parameter" vs. "argument" confusion. The size / type of the return value does not change to reflect the size/type of the expression passed to the function at a callsite - this sentence means "parameter." (Although honestly, this sentence adds little value - we should consider striking it.)