Skip to content

fix precondition on normal distribution #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

fix precondition on normal distribution #837

merged 1 commit into from
Mar 8, 2019

Conversation

Lorac
Copy link
Contributor

@Lorac Lorac commented Mar 8, 2019

The implementation has an assert for sigma should be strictly greater than 0.0.

@Lorac
fix precondition on normal distribution
cfba6de 
The implementation has an assert for sigma should be strictly greater than 0.0.
@PRMerger17
Copy link
Contributor

@Lorac : Thanks for your contribution! The author, @, has been notified to review your proposed change.

colin-home
colin-home approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for spotting this. I'm pretty sure a sigma of zero forms a singularity, not a normal distribution.

@Lorac
Copy link
Contributor Author

Lorac commented Mar 8, 2019

sigma of zero forms a singularity.

Yes indeed.

@colin-home colin-home merged commit 687487b into MicrosoftDocs:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-home colin-home colin-home approved these changes

Assignees

@colin-home colin-home

@Saisang Saisang

Labels
Change sent to author do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lorac @PRMerger17 @colin-home @Saisang