Skip to content

Commit 082e039

Browse files
committed
Review feedback
1 parent 3662a65 commit 082e039

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

docs/ide/reference/output-window.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ If you use autoscrolling in the **Output** window and then navigate by using the
6969

7070
## Structured Diagnostics
7171

72-
C++ MSBuild projects may emit structured diagnostics. The level of indentation of a diagnostic in the **Output** window represents the nested structure of the information. This indentation can be enabled or disabled with the **Project** > **Properties** > **Advanced** > **Enable MSVC Structured Output** option. You can affect several projects by creating a [Directory.Build.props](/visualstudio/msbuild/customize-by-directory) file with the **UseStructuredOutput** property defined to true or false.
72+
C++ MSBuild projects might emit structured diagnostics. The level of indentation of a diagnostic in the **Output** window represents the nested structure of the information. Enable or disable indentation with the **Project** > **Properties** > **Advanced** > **Enable MSVC Structured Output** option. You can affect several projects by creating a [Directory.Build.props](/visualstudio/msbuild/customize-by-directory) file with the **UseStructuredOutput** property defined to true or false.
7373

7474
## See also
7575

docs/ide/reference/problem-details-window.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,37 +17,37 @@ ms.technology: vs-ide-general
1717

1818
[!INCLUDE [Visual Studio](~/includes/applies-to-version/vs-windows-only.md)]
1919

20-
The **Problem Details** window enables you to view and navigate structured diagnostics issued by the MSVC compiler or [code analysis for C/C++](/cpp/code-quality/code-analysis-for-c-cpp-overview).
20+
The **Problem Details** window shows structured diagnostics issued by the MSVC compiler or [code analysis for C/C++](/cpp/code-quality/code-analysis-for-c-cpp-overview).
2121

22-
You can open the **Problem Details** window by interacting with entries in the [**Error List** window](error-list-window.md) that show an icon in their **Details** column to indicate that structured diagnostics are available for that entry.
22+
Select entries in the [**Error List** window](error-list-window.md) that show an icon in the **Details** column to open the **Problem Details** window. The **Problem Details** window shows the structured diagnostics for the selected entry.
2323

2424
:::image type="complex" source="media/error-list-details-column.png" alt-text="Screenshot of the Visual Studio Error List with one entry that has an icon in its details column.":::
2525
Screenshot of the Visual Studio Error List. It shows a table with a single row. The row represents a compiler error and contains the error code C2665, the description "pet: no overloaded function could convert all the argument types", and an icon of a square with the corner magnified in the column named Details. This icon is highlighted.
2626
:::image-end:::
2727

28-
Such entries are produced in two scenarios:
28+
Two scenarios produce these diagnostics:
2929

30-
1. C++ compilations using [**MSBuild**](/cpp/build/creating-and-managing-visual-cpp-projects) and the MSVC compiler may emit structured diagnostics.
31-
2. Code analysis warnings that support [**Key Event**](https://devblogs.microsoft.com/cppblog/microsoft-cpp-code-analysis-warnings-with-key-events) data emit structured diagnostics.
30+
- C++ compilations using [**MSBuild**](/cpp/build/creating-and-managing-visual-cpp-projects) and the MSVC compiler may emit structured diagnostics.
31+
- Code analysis warnings that support [**Key Event**](https://devblogs.microsoft.com/cppblog/microsoft-cpp-code-analysis-warnings-with-key-events) data emit structured diagnostics.
3232

33-
To open the **Problem Details** window for such an entry, you can either:
33+
Open the **Problem Details** window by doing one of the following:
3434

35-
- Double click on the entry or press **Enter** with the entry highlighted (this behavior can be disabled with **Tools** > **Options** > **Text Editor** > **C/C++** > **Advanced** > **Show Problem Details on Double Click**).
36-
- Single click on the icon in the **Details** column.
37-
- Open the shortcut menu for the entry and click the **Open Problem Details** option.
35+
- While the entry is highlighted, double-click it or press **Enter**. Disable this behavior with **Tools** > **Options** > **Text Editor** > **C/C++** > **Advanced** > **Show Problem Details on Double Click**.
36+
- Select the icon in the **Details** column.
37+
- Open the shortcut menu for the entry and select the **Open Problem Details** option.
3838

39-
By default, the **Problem Details** window opens in the same location as the **Error List** window. If you move the **Problem Details** window and close it, then when it is reopened, it opens in the same location at which it was closed.
39+
By default, the **Problem Details** window opens in the same location as the **Error List** window. Change where the **Problem Details** window opens by moving it to the desired position.
4040

4141
The **Problem Details** window displays structured information that may be nested. When the window opens, all entries that have nested children begin collapsed.
4242

4343
:::image type="complex" source="media/problem-details-collapsed.png" alt-text="Screenshot of the Visual Studio Problem Details window with all children collapsed.":::
44-
Screenshot of the Visual Studio Problem Details window. There is a header showing the same error code and description as the Error List entry from before. There is also a clickable link with the text cppcon-diag.cpp (Line 23). Below this header there are four lines of text. The first line says "Could be void pet(cat)." The second line says "or void pet(dog)." The third says "or void pet(_T0)." The last one says "while trying to match the argument list (lizard)." To the right of each line is grey text showing the file and line numbers for each entry. All of them belong to cppcon-diag.cpp and the line numbers are 7, 6, 18, and 23, respectively. To the left of the first three lines are small hollow arrows pointing right that signify that these entries can be expanded, but are currently not.
44+
Screenshot of the Visual Studio Problem Details window. There is a header showing the same error code and description as the Error List entry from before. There is also a selectable link with the text cppcon-diag.cpp (Line 23). Below this header there are entries explaining that this could be void pet(cat), void pet(dog), or void pet(_T0). The final entry states "while trying to match the argument list (lizard)." To the right of each line is grey text showing the file and line numbers for each entry. All of them belong to cppcon-diag.cpp and the line numbers are 7, 6, 18, and 23, respectively. To the left of the first three entries are small hollow arrows pointing right that signify that these entries can be expanded, but are currently not.
4545
:::image-end:::
4646

47-
Expand an entry to view its children by either clicking on the arrow at the left-hand side of an entry, or by pressing **Right** with the entry highlighted.
47+
Expand an entry to view its children by either selecting the arrow at the left-hand side of an entry, or by pressing **Right** with the entry highlighted.
4848

4949
:::image type="complex" source="media/problem-details-expanded.png" alt-text="Screenshot of the Visual Studio Problem Details window with some children expanded.":::
50-
Screenshot of the Visual Studio Problem Details window. The contents are mostly the same as the previous screenshot, however some of the entries have been expanded so their child entries are visible. The first entry has been expanded, so its arrow is now filled in and is pointing down and right. There is a nested entry with the text "void pet(cat) cannot convert argument 1 from lizard to cat." This entry is indented and has its own hollow arrow at the left showing that it too can be expanded. The second line from before has been expanded, revealing an unexpanded entry reading "void pet(dog) cannot convert argument 1 from lizard to dog." The third entry has been expanded, revealing an entry reading "the associated constraints are not satisfied." This entry has an expanded child reading "the concept pettable lizard evaluated to false." This entry has two children. The first is unexpanded and reads "the concept has_member_pet lizard evaluated to false." The second is expanded and reads "the concept has_default_pet lizard evaluated to false." This second child has two children, neither of which is expandable. They read "is_pettable is not a member of lizard" and "see declaration of lizard."
50+
Screenshot of the Visual Studio Problem Details window. The contents are mostly the same as the previous screenshot, however some of the entries have been expanded so their child entries are visible. The first entry has been expanded. There is a nested entry with the text "void pet(cat) cannot convert argument 1 from lizard to cat." This entry is indented and can be expanded. The second line from before has been expanded, revealing an unexpanded entry reading "void pet(dog) cannot convert argument 1 from lizard to dog." The third entry has been expanded, revealing an entry reading "the associated constraints are not satisfied." This entry has an expanded child reading "the concept pettable lizard evaluated to false." This entry has two children. The first is unexpanded and reads "the concept has_member_pet lizard evaluated to false." The second is expanded and reads "the concept has_default_pet lizard evaluated to false." This second child has two children, neither of which is expandable. They read "is_pettable is not a member of lizard" and "see declaration of lizard."
5151
:::image-end:::
5252

5353
Enable or disable structured diagnostics with the **Project** > **Properties** > **Advanced** > **Enable MSVC Structured Output** option. You can affect several projects by creating a [Directory.Build.props](/visualstudio/msbuild/customize-by-directory) file with the **UseStructuredOutput** property defined to true or false.

0 commit comments

Comments
 (0)