Skip to content

Commit 0c26442

Browse files
authored
Apply suggestions from code review
1 parent e67c74e commit 0c26442

16 files changed

+15
-20
lines changed

docs/msbuild/item-functions.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ The table below lists the intrinsic functions available for items.
7171
> [!NOTE]
7272
> `Exists` can also be used in other contexts; in [MSBuild conditions](msbuild-conditions.md), for example `Condition="Exists('path')"`; or in [Static property functions](property-functions.md), for example `$([System.IO.File]::Exists("path"))`.
7373
74-
7574
The following example shows how to use intrinsic item functions.
7675

7776
```xml

docs/msbuild/msbuild-api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,4 @@ Documentation for the MSBuild API can be found by using the [.NET API Browser](/
5252
| [Microsoft.Build.Tasks.Xaml](/dotnet/api/Microsoft.Build.Tasks.Xaml?view=msbuild-16&preserve-view=true) | .NET Framework only | Contains classes related to XAML build tasks. |
5353
| [Microsoft.Build.Utilities](/dotnet/api/Microsoft.Build.Utilities?view=msbuild-16&preserve-view=true) | All | Contains helper classes that you can use to create your own MSBuild loggers and tasks.|
5454

55-
5655
In the previous table, All in the Applies To column means the types in the namespace are available in both the .NET Framework and the .NET Core versions of the MSBuild API.

docs/msbuild/msbuild-items.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,6 @@ Remarks:
557557
- Metadata conditions
558558
- Metadata name matching is case insensitive.
559559

560-
561560
## Updating metadata on items in an ItemGroup of a Target
562561

563562
Metadata can be modified inside targets too, by a less expressive syntax than `Update`:

docs/msbuild/walkthrough-using-msbuild.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ To install MSBuild on a system that doesn't have Visual Studio, go to Build Tool
6262
In the **Project name** box, type `BuildApp`. Enter a **Location** for the solution, for example, *D:\\*.
6363

6464

65-
6665
1. Click **OK** or **Create** to create the project file.
6766

6867
## Examine the project file

docs/profiling/beginners-guide-to-performance-profiling.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ We recommend that you begin analyzing your data by examining the list of functio
121121
![Diagnostics Tools Call Tree](../profiling/media/vs-2019/diag-tools-call-tree.png "DiagToolsCallTree")
122122

123123

124-
125124
|Image|Description|
126125
|-|-|
127126
|![Step 1](../profiling/media/ProcGuid_1.png "ProcGuid_1")|The top-level node in CPU Usage call trees is a pseudo-node|
@@ -141,7 +140,6 @@ We recommend that you begin analyzing your data by examining the list of functio
141140

142141
![Diagnostics Tools Hot Path](../profiling/media/vs-2019/diag-tools-hot-path.png "DiagToolsHotPath")
143142

144-
145143
> [!NOTE]
146144
> If you see code in the call tree marked as "broken" code or "unwalkable stack", this indicates that Event Tracing for Windows (ETW) events were likely dropped. Try collecting the same trace a second time to resolve the issue.
147145

docs/profiling/cpu-usage.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ The diagnostic report is sorted by **Total CPU**, from highest to lowest. Change
8080

8181
Starting in Visual Studio 2019, you can click the **Expand Hot Path** and **Show Hot Path** buttons to see the function calls that use the highest percentage of the CPU in the call tree view.
8282

83-
8483
### <a name="BKMK_Call_tree_data_columns"></a> CPU Usage data columns
8584

8685
|Name|Description|

docs/profiling/profiling-feature-tour.md

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,22 @@ Starting in Visual Studio 2019 version 16.7, you can use the [.NET Counters tool
229229
The tool shows live values for each counter in a list view.
230230

231231
:::image type="content" source="../profiling/media/dotnet-counters-tool-collecting.png" alt-text=".NET Counter tool collecting.":::
232+
## Analyze resource consumption (XAML)
232233

234+
In XAML apps, such as Windows desktop WPF apps and UWP apps, you can analyze resource consumption using the Application Timeline tool. For example, you can analyze the time spent by your application preparing UI frames (layout and render), servicing network and disk requests, and in scenarios like application startup, page load, and Window resize. To use the tool, choose **Application Timeline** in the Performance Profiler, and then choose **Start**. In your app, go through the scenario with a suspected resource consumption issue, and then choose **Stop collection** to generate the report.
235+
236+
Low framerates in the **Visual throughput** graph may correspond to visual problems that you see when running your app. Similarly, high numbers in the **UI thread utilization** graph may also correspond to UI responsiveness issues. In the report, you can select a time period with a suspected performance issue, and then examine the detailed UI thread activities in the Timeline details view (lower pane).
237+
238+
::: moniker range=">=vs-2022"
239+
![Application Timeline profiling tool](../profiling/media/vs-2022/prof-tour-application-timeline.png "Profiling Tour Application Timeline")
240+
::: moniker-end
241+
::: moniker range="vs-2019"
242+
![Application Timeline profiling tool](../profiling/media/prof-tour-application-timeline.gif "Profiling Tour Application Timeline")
243+
::: moniker-end
244+
245+
In the Timeline details view, you can find information such as the type of activity (or the UI element involved) along with the duration of the activity. For example, in the illustration, a **Layout** event for a Grid control takes 57.53 ms.
246+
247+
For more information, see [Application Timeline](../profiling/application-timeline.md).
233248
## Examine UI performance and accessibility events (UWP)
234249

235250
In your UWP apps, you can enable **UI Analysis** in the **Diagnostic Tools** window. The tool searches for common performance or accessibility issues and displays them in the **Events** view while you are debugging. The event descriptions provide information that can help resolve issues.
@@ -258,7 +273,6 @@ You can also use the graphs to determine whether there are CPU bound or GPU boun
258273

259274
## Analyze performance (legacy tools)
260275

261-
262276
In Visual Studio 2019, the legacy Performance Explorer and related profiling tools such as the Performance Wizard were folded into the Performance Profiler, which you can open using **Debug** > **Performance Profiler**. In the Performance Profiler, the available diagnostics tools depend on the target chosen and the current, open startup project. The CPU Usage tool provides the sampling capability previously supported in the Performance Wizard. The Instrumentation tool provides the instrumented profiling capability (for precise call counts and durations) that was in the Performance Wizard. Additional memory tools also appear in the Performance Profiler.
263277

264278
![Performance Explorer tool](../profiling/media/prof-tour-performance-explorer.png "Performance Explorer")
@@ -284,6 +298,5 @@ Here is a table that lists the different tools Visual Studio offers and the diff
284298

285299

286300

287-
288301
## See also
289302
- [Debugging in Visual Studio](../debugger/debugger-feature-tour.md)

docs/python/data-science-and-analytical-applications-workload.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ The Data Science and Analytical Applications workload, which you select and inst
2727

2828
Python is a primary scripting language used for data science. Python is easy to learn and is supported by a rich ecosystem of packages. Those packages address a wide range of scenarios such as data acquisition, cleaning, model training, deployment, and plotting. F# is also a powerful functional-first .NET language that's suited for a wide variety of data processing tasks.)
2929

30-
3130
<!--Note link on the image because this one is large -->
3231
[![Screenshots of Visual Studio with R, Python, and F#](media/workload/data-science-workload-screens.png)](media/workload/data-science-workload-screens.png#lightbox)
3332

@@ -46,7 +45,6 @@ By default, the workload installs the following options, which you can modify in
4645

4746
SQL Server supports using Python to do advanced analytics directly inside SQL Server. Python support is available in SQL Server 2017 CTP 2.0 and later.
4847

49-
5048
You enjoy the following advantages by running your code where your data already lives:
5149

5250
- **Elimination of data movement**: Instead of moving data from the database to your application or model, you can build applications in the database. This capability eliminates barriers of security, compliance, governance, integrity, and a host of similar issues related to moving vast amounts of data around. You can also consume datasets that couldn't fit into the memory of a client machine.

docs/python/editing-python-code-in-visual-studio.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ Using the **Run Mypy** command on this code generates the following error:
113113
>
114114
> At present, Visual Studio doesn't support type hints in comments.
115115
116-
117116
### Signature help
118117

119118
When writing code that calls a function, signature help appears when you type the opening `(` and displays available documentation and parameter information. You can also make it appear with **Ctrl**+**Shift**+**Space** inside a function call. The information displayed depends on the documentation strings in the function's source code, but includes any default values.

docs/python/installing-python-interpreters.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ You can also manually install any of the interpreters listed in the table below
2626
> [!Note]
2727
> Visual Studio supports Python version 3.7. While it is possible to use Visual Studio to edit code written in other versions of Python, those versions are not officially supported and features such as IntelliSense and debugging might not work.
2828
29-
3029
For **Visual Studio 2015 and earlier**, you must manually install one of the interpreters.
3130

3231
> [!Note]

docs/python/learn-django-in-visual-studio-step-01-project-and-solution.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ In this tutorial, you learn how to:
2828
- Use the Django Web Project template to create an app with multiple pages and responsive design (step 4).
2929
- Authenticate users (step 5).
3030

31-
3231
## Prerequisites
3332

3433
::: moniker range="<=vs-2019"

docs/python/learn-django-in-visual-studio-step-02-create-an-app.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ Using either method, create an app with the name "HelloDjangoApp". Now, the "Hel
6363
| **tests.py** | A Python file that contains the basic structure of unit tests. |
6464
| **views.py** | Views are similar to web pages, which take an HTTP request and returns an HTTP response. Usually, views render as HTML and the web browsers know how to display, but a view doesn't necessarily have to be visible (like an intermediate form). A view is defined by a Python function whose responsibility is to render the HTML to the browser. The *views.py* file is a default place where you create your views. Initially, the *views.py* file contains only the statement, `from django.shortcuts import render`. |
6565

66-
6766
When you use the name "HelloDjangoApp," the contents of the *apps.py* file appears as:
6867

6968
```python

docs/python/learn-django-in-visual-studio-step-05-django-authentication.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ ms.workload:
2222

2323
The "Django Web Project" template includes a basic authentication flow, as authentication is a common need for web apps. When you use any of the Django project templates, Visual Studio includes all the necessary modules for authentication in the Django project's *settings.py* file.
2424

25-
2625
In this step, you learn:
2726

2827
> [!div class="checklist"]

docs/python/learn-flask-visual-studio-step-01-project-solution.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ In this tutorial, you learn how to:
3232

3333
Over the course of these steps you create a single Visual Studio solution that contains two separate projects. You create the project using different Flask project templates that are included with Visual Studio. By keeping the projects in the same solution, you can easily switch back and forth between different files for comparison.
3434

35-
3635
> [!Note]
3736
> This tutorial differs from the [Flask Quickstart](../ide/quickstart-python.md?toc=/visualstudio/python/toc.json&bc=/visualstudio/python/_breadcrumb/toc.json) in that you learn more about Flask as well as how to use the different Flask project templates that provide a more extensive starting point for your own projects. For example, the project templates automatically install the Flask package when creating a project, rather than needing you to install the package manually as shown in the Quickstart.
3837

docs/python/managing-python-environments-in-visual-studio.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ If you're new to Python in Visual Studio, the following articles also provide fr
3636
> [!Note]
3737
> You can manage environments for Python code that is opened as a folder using the **File** > **Open** > **Folder** command. The Python toolbar allows you switch between all detected environments, and also add a new environment. The environment information is stored in the PythonSettings.json file in the Workspace .vs folder.
3838
39-
4039
## The Python Environments window
4140

4241
The environments that Visual Studio knows about are displayed in the **Python Environments** window. To open the window, use one of the following methods:
@@ -295,7 +294,6 @@ If Visual Studio finds registry entries for an environment, but the path to the
295294

296295
![The Python Environments window showing an invalid environment-2019-2022](media/environments/environments-invalid-entry-2019.png)
297296

298-
299297
To correct an environment you wish to keep, first try using its installer's **Repair** process. The installers for standard Python 3.x, for example, include that option.
300298

301299
## Modify the registry to correct an environment that doesn't have a repair option, or to remove an invalid environment

docs/python/managing-python-projects-in-visual-studio.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ Visual Studio provides a variety of Python project templates to quickly set up a
2929
> [!Tip]
3030
> Visual Studio 2019 supports opening a folder containing Python code and running that code without creating Visual Studio project and solution files. For more information, see [Quickstart: Open and run Python code in a folder](quickstart-05-python-visual-studio-open-folder.md). There are, however, benefits to using a project file, as explained in this section.
3131
32-
3332
> [!Tip]
3433
> Without a project, all versions of Visual Studio work well with Python code. For example, you can open a Python file by itself and enjoy auto-complete, IntelliSense, and debugging (by right-clicking in the editor and selecting **Start with Debugging**). Because such code always uses the default global environment, however, you may see incorrect completions or errors if the code is meant for a different environment. Furthermore, Visual Studio analyzes all files and packages in the folder from which the single file is opened, which could consume considerable CPU time.
3534
>

0 commit comments

Comments
 (0)