Merge pull request #33 from MicrosoftDocs/master

bringing in newest changes

Author: WilliamAntonRohm

.openpublishing.redirection.json

@@ -1570,6 +1570,11 @@
             "redirect_url": "/visualstudio/extensibility/walkthrough-creating-a-basic-isolated-shell-application",
             "redirect_document_id": false
         },
+        {
+            "source_path": "docs/get-started/csharp/tutorial-projects-solutions.md",
+            "redirect_url": "/visualstudio/get-started/tutorial-projects-solutions",
+            "redirect_document_id": false
+        },
         {
             "source_path": "docs/ide/how-to-target-a-version-of-the-dotnet-framework.md",
             "redirect_url": "/visualstudio/ide/visual-studio-multi-targeting-overview",
@@ -7879,6 +7884,61 @@
             "source_path": "subscriptions/vs-xamarin.md",
             "redirect_url": "/visualstudio/subscriptions",
             "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/signing-in.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/subscriber-downloads.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/subscriber-benefits.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/join-dev-essentials.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/professional-development.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/technical-support.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/subscription-management-info.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/vlsc-admin-faq.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/find-pcn.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/find-primary-contact.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
+        },
+        {
+            "source_path": "subscriptions/volume-license-onboarding-email.md",
+            "redirect_url": "/visualstudio/subscriptions",
+            "redirect_document_id": false
         }
     ]
 }

docs/code-quality/c26478.md

@@ -0,0 +1,56 @@
+---
+title: c26478
+keywords: c26478
+author: JordanMaples
+ms.author: jomaples
+ms.date: 07/15/2019
+ms.topic: reference
+ms.technology: vs-ide-code-analysis
+f1_keywords:
+  - "c26478"
+helpviewer_keywords:
+  - "c26478"
+dev_langs: ["C++"]
+manager: annagrin
+---
+# Warning C26478: Don't use std::move on constant variables. (es.56)
+
+This warning is to indicate that the use of std::move not consistent with how std::move is intended to be used.
+
+When called on a const object, std::move returns a copy of the object, which is likely not the developer's intent.
+
+## Example 1
+
+```cpp
+struct node
+{
+    node* next;
+    int id;
+}
+
+void foo(const node& n)
+{
+    const node local = std::move(n); // C26478 reported here
+    // ...
+}
+```
+
+An assignment operator or using the passed in parameter will prevent this warning from being issued and will adequately serve the developer's use case.
+
+## Example 2
+
+```cpp
+struct s;
+
+template <typename T>
+void bar(T t){};
+
+void foo()
+{
+    const s s1;
+    bar(std::move(s1)); // C26478 reported here
+}
+```
+
+## See also
+[ES.56 - Write std::move() only when you need to explicitly move an object to another scope](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es56-write-stdmove-only-when-you-need-to-explicitly-move-an-object-to-another-scope)

docs/code-quality/c26812.md

@@ -0,0 +1,51 @@
+---
+title: c26812
+keywords: c26812
+author: JordanMaples
+ms.author: jomaples
+ms.date: 07/15/2019
+ms.topic: reference
+ms.technology: vs-ide-code-analysis
+f1_keywords:
+  - "c26812"
+helpviewer_keywords:
+  - "c26812"
+dev_langs: ["C++"]
+manager: annagrin
+---
+
+# Warning C26812 Prefer 'enum class' over 'enum' (Enum.3)
+The enum type %type% is unscoped. Prefer 'enum class' over 'enum' (Enum.3)
+
+## Example
+The following example is from the C++ Core Guidelines
+
+```cpp
+void Print_color(int color);
+
+enum Web_color { red = 0xFF0000, green = 0x00FF00, blue = 0x0000FF }; // C26812 reported here
+enum Product_info { Red = 0, Purple = 1, Blue = 2 }; // C26812 reported here
+
+Web_color webby = Web_color::blue;
+
+// Clearly at least one of these calls is buggy.
+Print_color(webby);
+Print_color(Product_info::Blue);
+```
+
+These warnings are corrected by declaring the enum as enum class:
+
+```cpp
+void Print_color(int color);
+
+enum class Web_color { red = 0xFF0000, green = 0x00FF00, blue = 0x0000FF }; // no C26812
+enum class Product_info { red = 0, purple = 1, blue = 2 }; // no C26812
+
+Web_color webby = Web_color::blue;
+Print_color(webby);  // Error: cannot convert Web_color to int.
+Print_color(Product_info::Red);  // Error: cannot convert Product_info to int.
+```
+
+## See also
+
+[Enum.3 Prefer enum class over enum](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#enum3-prefer-class-enums-over-plain-enums )

docs/code-quality/c26814.md

@@ -0,0 +1,36 @@
+---
+title: c26814
+keywords: c26814
+author: JordanMaples
+ms.author: jomaples
+ms.date: 07/15/2019
+ms.topic: reference
+ms.technology: vs-ide-code-analysis
+f1_keywords:
+  - "c26814"
+helpviewer_keywords:
+  - "c26814"
+dev_langs: ["C++"]
+manager: annagrin
+---
+
+# Warning C26814 Use constexpr for constants whose value is known at compile time. (Con.5)
+The const variable '%variable%' can be computed at compile time. Consider using constexpr (con.5)
+
+## Example
+```cpp
+const int foo = 1234;  // C26814 reported here.
+constexpr int getMagicNumber()
+{
+    return 42;
+}
+
+void bar()
+{
+    const int myval = 3; // C26814 reported here
+    const int magicNumber = getMagicNumber(); // C26814 reported here.
+}
+```
+
+## See also
+[Con.5 Use constexpr for all variables that can be computed at compile time](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rconst-constexpr)

docs/code-quality/ca2202-do-not-dispose-objects-multiple-times.md

@@ -1,6 +1,6 @@
 ---
 title: "CA2202: Do not dispose objects multiple times"
-ms.date: 11/04/2016
+ms.date: 07/16/2019
 ms.topic: reference
 f1_keywords:
   - "CA2202"
@@ -77,11 +77,13 @@ try
 }
 finally
 {
-    if(stream != null)
-        stream.Dispose();
+    stream?.Dispose();
 }
 ```
 
+> [!TIP]
+> The `?.` syntax above is the [null-conditional operator](/dotnet/csharp/language-reference/operators/member-access-operators#null-conditional-operators--and-).
+
 ## See also
 
 - <xref:System.IDisposable?displayProperty=fullName>

docs/code-quality/configure-fxcop-analyzers.md

@@ -118,3 +118,4 @@ The syntax for configuring an option for a specific rule is as follows:
 
 - [Analyzer configuration](https://github.com/dotnet/roslyn-analyzers/blob/master/docs/Analyzer%20Configuration.md)
 - [FxCop analyzers](install-fxcop-analyzers.md)
+- [.NET coding conventions for EditorConfig](../ide/editorconfig-code-style-settings-reference.md)

docs/code-quality/toc.yml

@@ -146,7 +146,7 @@
     - name: Create a custom rule set
       href: how-to-create-a-custom-rule-set.md
     - name: Use the rule set editor
-      href: working-in-the-code-analysis-rule-set-editor.md  
+      href: working-in-the-code-analysis-rule-set-editor.md
   - name: Code metrics
     items:
     - name: Overview
@@ -956,6 +956,8 @@
       href: C26476.md
     - name: C26477
       href: C26477.md
+    - name: C26478
+      href: c26478.md
     - name: C26481
       href: C26481.md
     - name: C26482
@@ -990,6 +992,10 @@
       href: C26497.md
     - name: C26498
       href: C26498.md
+    - name: C26812
+      href: c26812.md
+    - name: C26814
+      href: c26814.md
   - name: C/C++ warnings
     items:
     - name: Overview

docs/data-tools/connect-to-data-in-an-access-database-windows-forms.md

@@ -1,12 +1,10 @@
 ---
-title: Connect to data in an Access database (Windows Forms)
-ms.date: 02/12/2019
+title: Connect to data in an Access database
+ms.date: 07/18/2019
 ms.topic: conceptual
 helpviewer_keywords:
-  - "databases, connecting to"
-  - "databases, Access"
   - "data [Visual Studio], connecting"
-  - "connecting to data, from Access databases"
+  - "connecting to data, Access databases"
   - "Access databases, connecting"
 ms.assetid: 4159e815-d430-4ad0-a234-e4125fcbef18
 author: gewarren
@@ -15,19 +13,19 @@ manager: jillfra
 ms.workload:
   - "data-storage"
 ---
-# Connect to data in an Access database (Windows Forms)
+# Connect to data in an Access database
 
-You can connect to an Access database (either an *.mdb* file or an *.accdb* file) by using Visual Studio. After you define the connection, the data appears in the **Data Sources** window. From there, you can drag tables or views onto your forms.
+You can connect to an Access database (either an *.mdb* file or an *.accdb* file) by using Visual Studio. After you define the connection, the data appears in the **Data Sources** window. From there, you can drag tables or views onto your design surface.
 
 ## Prerequisites
 
-To use these procedures, you need a Windows Forms application project, and either an Access database (*.accdb* file) or an Access 2000-2003 database (*.mdb* file). Follow the procedure that corresponds to your file type.
+To use these procedures, you need a Windows Forms or WPF project and either an Access database (*.accdb* file) or an Access 2000-2003 database (*.mdb* file). Follow the procedure that corresponds to your file type.
 
 ## Create a dataset for an .accdb file
 
-You can connect to databases created through Access 2013, Office 365, Access 2010, or Access 2007 by using the following procedure.
+Connect to databases created with Office 365, Access 2013, Access 2010, or Access 2007 by using the following procedure.
 
-1. Open the Windows Forms application to which you want to connect data.
+1. Open a Windows Forms or WPF application project in Visual Studio.
 
 2. To open the **Data Sources** window, on the **View** menu, select **Other Windows** > **Data Sources**.
 
@@ -55,21 +53,21 @@ You can connect to databases created through Access 2013, Office 365, Access 201
 
 10. Select **Next** on the **Choose your Data Connection** page.
 
-     You may get a dialog box telling you the data file is not in your current project. Select **Yes** or **No**.
+    You may get a dialog box telling you the data file is not in your current project. Select **Yes** or **No**.
 
 11. Select **Next** on the **Save connection string to the Application Configuration file** page.
 
 12. Expand the **Tables** node on the **Choose your Database Objects** page.
 
 13. Select the tables or views you want to include in your dataset, and then select **Finish**.
 
-     The dataset is added to your project, and the tables and views appear in the **Data Sources** window.
+    The dataset is added to your project, and the tables and views appear in the **Data Sources** window.
 
 ## Create a dataset for an .mdb file
 
-You create the dataset by running the **Data Source Configuration Wizard**.
+Connect to databases created with Access 2000-2003 by using the following procedure.
 
-1. Open the Windows Forms application to which you want to connect data.
+1. Open a Windows Forms or WPF application project in Visual Studio.
 
 2. On the **View** menu, select **Other Windows** > **Data Sources**.
 
@@ -101,15 +99,11 @@ You create the dataset by running the **Data Source Configuration Wizard**.
 
     The dataset is added to your project, and the tables and views appear in the **Data Sources** window.
 
-## Security
-
-Storing sensitive information (such as a password) can affect the security of your application. Using Windows Authentication (also known as integrated security) is a more secure way to control access to a database. For more information, see [Protecting connection information](/dotnet/framework/data/adonet/protecting-connection-information).
-
 ## Next steps
 
-The dataset that you just created is now available in the **Data Sources** window. You can now perform any of the following tasks:
+The dataset that you just created is available in the **Data Sources** window. You can now perform any of the following tasks:
 
-- Select items in the **Data Sources** window and drag them onto your form (see [Bind Windows Forms controls to data in Visual Studio](../data-tools/bind-windows-forms-controls-to-data-in-visual-studio.md)).
+- Select items in the **Data Sources** window and drag them onto your form or design surface (see [Bind Windows Forms controls to data in Visual Studio](../data-tools/bind-windows-forms-controls-to-data-in-visual-studio.md) or [WPF data binding overview](/dotnet/framework/wpf/data/data-binding-overview)).
 
 - Open the data source in the **Dataset Designer** to add or edit the objects that make up the dataset.
 
@@ -118,3 +112,5 @@ The dataset that you just created is now available in the **Data Sources** windo
 ## See also
 
 - [Add connections](../data-tools/add-new-connections.md)
+- [WPF data binding overview](/dotnet/framework/wpf/data/data-binding-overview)
+- [Windows Forms data binding](/dotnet/framework/winforms/data-binding-and-windows-forms)