Merge pull request #3089 from MicrosoftDocs/master636910335012482722

For protected CLA branch, push strategy should use PR and merge to target branch method to work around git push error

Author: gewarren

docs/cross-platform/using-visual-studio-tools-for-unity.md

@@ -186,6 +186,9 @@ Note that the scenario described here assumes that you have the source code—th
 
 2. Reference the correct Unity framework profile in the DLL project. In Visual Studio, in the DLL project's properties, set the **Target framework** property to the Unity framework version you're using. This is the Unity Base Class Library that matches the API compatibility that your project targets, such as the Unity full, micro, or web base class libraries. This prevents your DLL from calling framework methods that exist in other frameworks or compatibility levels, but which might not exist in the Unity framework version you're using.
 
+> [!NOTE]
+> The following is only required if you are using Unity's legacy runtime. If you are using the new Unity runtime, you don't need to use those dedicated 3.5 profiles anymore. Use a .NET 4.x profile compatible with your Unity version.
+
    ![Set the DLL's target framework to Unity framework.](../cross-platform/media/vstu_debugging_dll_target_framework.png "vstu_debugging_dll_target_framework")
 
 3. Copy the DLL to your Unity project's Asset folder. In Unity, assets are files that are packaged and deployed together with your Unity app so that they can be loaded at run-time. Since DLLs are linked at runtime, DLLs must be deployed as assets. To be deployed as an asset, the Unity Editor requires the DLLs to be put inside the Assets folder in your Unity project. There are two ways you can do this:
@@ -194,7 +197,9 @@ Note that the scenario described here assumes that you have the source code—th
 
    - Modify the build settings of your DLL project to set its output folder to be the **Assets** folder of your Unity project. Both DLL and PDB files will be placed in the **Assets** folder.
 
-   The PDB files are needed for debugging because they contain the DLL's debugging symbols, and map the DLL code to its source code form. Visual Studio Tools for Unity will use information from the DLL and PDB to create a DLL.MDB file, which is the debug symbol format used by the Unity scripting engine.
+   The PDB files are needed for debugging because they contain the DLL's debugging symbols, and map the DLL code to its source code form. If you are targeting the legacy runtime, Visual Studio Tools for Unity will use information from the DLL and PDB to create a DLL.MDB file, which is the debug symbol format used by the the legacy Unity scripting engine. If you are targeting the new runtime, and using Portable-PDB, Visual Studio Tools for Unity will not try to do any symbol conversion as the new Unity runtime is able to natively consume Portable-PDBs.
+   
+   More information about PDB generation can be found [here](https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-set-debug-and-release-configurations?view=vs-2019). If you are targeting the new runtime, please make sure that "Debugging Information" is set to "Portable", in order to properly generate Portable-PDB. If you are targeting the legacy runtime, you need to use "Full".
 
 4. Debug your code. You can now debug your DLL source code together with your Unity project's source code, and use all the debugging features you are used to, such as breakpoints and stepping through code.
 

docs/data-tools/accessing-data-in-visual-studio.md

@@ -21,7 +21,7 @@ In Visual Studio, you can create applications that connect to data in virtually
 
 For applications in JavaScript, Python, PHP, Ruby, or C++, you connect to data like you do anything else, by obtaining libraries and writing code. For .NET applications, Visual Studio provides tools that you can use to explore data sources, create object models to store and manipulate data in memory, and bind data to the user interface. Microsoft Azure provides SDKs for .NET, Java, Node.js, PHP, Python, Ruby, and mobile apps, and tools in Visual Studio for connecting to Azure Storage.
 
-The following lists show just a few of the many database and storage systems that can be used from Visual Studio. The [Microsoft Azure](https://azure.microsoft.com/) offerings are data services that include all provisioning and administration of the underlying data store. The **Azure development** workload in [Visual Studio 2017](https://visualstudio.microsoft.com/downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=inline+link&utm_content=download+vs2017) enables you to work with Azure data stores directly from Visual Studio.
+The following lists show just a few of the many database and storage systems that can be used from Visual Studio. The [Microsoft Azure](https://azure.microsoft.com/) offerings are data services that include all provisioning and administration of the underlying data store. The **Azure development** workload in [Visual Studio 2017](https://visualstudio.microsoft.com/vs/older-downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=vs+2017+download) enables you to work with Azure data stores directly from Visual Studio.
 
 ![Azure development workload](media/azure-development-workload.png)
 

docs/debugger/debug-live-azure-applications.md

@@ -30,7 +30,7 @@ In this tutorial, you will:
 
 * Snapshot Debugger is only available for Visual Studio 2017 Enterprise version 15.5 or higher with the **Azure development workload**. (Under the **Individual components** tab, you find it under **Debugging and testing** > **Snapshot debugger**.)
 
-    If it's not already installed, install [Visual Studio 2017 Enterprise version 15.5](https://visualstudio.microsoft.com/downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=inline+link&utm_content=download+vs2017) or later. If you are updating from a previous Visual Studio 2017 installation, run the Visual Studio Installer and check the Snapshot Debugger component in the **ASP.NET and web development workload**.
+    If it's not already installed, install [Visual Studio 2017 Enterprise version 15.5](https://visualstudio.microsoft.com/vs/older-downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=vs+2017+download) or later. If you are updating from a previous Visual Studio 2017 installation, run the Visual Studio Installer and check the Snapshot Debugger component in the **ASP.NET and web development workload**.
 
 * Basic or higher Azure App Service plan.
 

docs/debugger/debug-live-azure-kubernetes.md

@@ -29,9 +29,9 @@ In this tutorial, you will:
 
 ## Prerequisites
 
-* Snapshot Debugger for Azure Kubernetes Services is only available for Visual Studio 2019 Enterprise preview or higher with the **Azure development workload**. (Under the **Individual components** tab, you find it under **Debugging and testing** > **Snapshot debugger**.)
+* Snapshot Debugger for Azure Kubernetes Services is only available for Visual Studio 2019 Enterprise or higher with the **Azure development workload**. (Under the **Individual components** tab, you find it under **Debugging and testing** > **Snapshot debugger**.)
 
-    If it's not already installed, install [Visual Studio 2019 Enterprise preview](https://visualstudio.microsoft.com/vs/preview/).
+    If it's not already installed, install [Visual Studio 2019 Enterprise](https://visualstudio.microsoft.com/vs/).
 
 * Snapshot collection is available for the following Azure Kubernetes Services web apps:
   * ASP.NET Core applications running on .NET Core 2.2 or later on Debian 9.

docs/debugger/debug-live-azure-virtual-machines-time-travel-debugging.md

@@ -0,0 +1,113 @@
+---
+title: "Time Travel Debugging live ASP.NET Azure virtual machines"
+description: "Learn how to record and replay live ASP.NET apps on Azure virtual machines using the Snapshot Debugger."
+ms.custom: ""
+ms.date: "04/11/2019"
+ms.topic: "conceptual"
+helpviewer_keywords:
+  - "debugger"
+author: "poppastring"
+ms.author: "madownie"
+manager: andster
+monikerRange: '>= vs-2019'
+ms.workload:
+  - "aspnet"
+  - "azure"
+---
+# Record and replay live ASP.NET apps on Azure virtual machines using the Snapshot Debugger
+
+The Time Travel Debugging (TTD) preview in Visual Studio Enterprise provides the ability to record a Web app running on a Azure Virtual Machine (VM) and then accurately reconstruct and replay the execution path. TTD integrates with our Snapshot Debugger offering and allows you to rewind and replay each line of code however many times you want, helping you isolate and identify problems that might only occur in production environments.
+
+Capturing a TTD recording will not halt the application, however, recording will add significant overhead to your running process, slowing it down based on factors that include the process size and the number of active threads.
+
+This feature is in preview for the release of Visual Studio 2019 with a go live license.
+
+In this tutorial, you will:
+
+> [!div class="checklist"]
+> * Start the Snapshot Debugger with Time Travel Debugging enabled
+> * Set a snappoint and Collect a Time Travel recording
+> * Start Debugging a Time Travel recording
+
+## Prerequisites
+
+* Time Travel Debugging for Azure Virtual Machines (VM)  is only available for Visual Studio 2019 Enterprise or higher with the **Azure development workload**. (Under the **Individual components** tab, you find it under **Debugging and testing** > **Snapshot debugger**.)
+
+    If it's not already installed, install [Visual Studio 2019 Enterprise](https://visualstudio.microsoft.com/vs/).
+
+* Time Travel Debugging is available for the following Azure VM web apps:
+  * ASP.NET applications (AMD64) running on .NET Framework 4.8 or later.
+
+## Open your project and start the Snapshot Debugger with Time Travel Debugging enabled
+
+1. Open the project that you would like to Collect a Time Travel recording.
+
+    > [!IMPORTANT]
+    > To start TTD, you need to open the *same version of source code* that is published to your Azure VM service.
+
+1. Choose **Debug > Attach Snapshot Debugger...**. Select the Azure VM your web app is deployed to and an Azure storage account. Select the **Enable the Time Travel Debugging** preview option and then click **Attach**.
+
+      ![Select Azure Resource](../debugger/media/time-travel-debugging-select-azure-resource-vm.png)
+
+    > [!IMPORTANT]
+    > The first time you select **Attach Snapshot Debugger** for your VM, IIS is automatically restarted.
+
+    The metadata for the **Modules** will not initially be activated, navigate to the web app and the **Start Collection** button will become active. Visual Studio is now in snapshot debugging mode.
+
+   ![Snapshot debugging mode](../debugger/media/snapshot-message.png)
+
+    > [!NOTE]
+    > The Application Insights site extension also supports Snapshot Debugging. If you encounter a "site extension out of date" error message, see [troubleshooting tips and known issues for snapshot debugging](../debugger/debug-live-azure-apps-troubleshooting.md) for upgrading details.
+
+   The **Modules** window shows you when all the modules have loaded for the Azure VM (choose **Debug > Windows > Modules** to open this window).
+
+   ![Check the Modules window](../debugger/media/snapshot-modules.png)
+
+## Set a snappoint and Collect a Time Travel recording
+
+1. In the code editor, click the left gutter in a method you are interested in to set a snappoint. Make sure it is code that you know will execute.
+
+   ![Set a snappoint](../debugger/media/time-travel-debugging-set-snappoint-settings.png)
+
+1. Right-click the snappoint icon (the hollow ball) and choose **Actions**. In the Snapshot Settings window click the **Action** check box. Then click the **Collect a time travel trace to the end of this method** check box.
+
+   ![Collect a time travel trace to the end of the method](../debugger/media/time-travel-debugging-set-snappoint-action.png)
+
+1. Click **Start Collection** to turn on the snappoint.
+
+   ![Turn on the snappoint](../debugger/media/snapshot-start-collection.png)
+
+## Take a snapshot
+
+When a snappoint is turned on, it will capture a snapshot whenever the line of code where the snappoint is placed executes. This execution can be caused by a real request on your server. To force your snappoint to hit, go to the browser view of your web site and take any actions required that cause your snappoint to be hit.
+
+## Start Debugging a Time Travel recording
+
+1. When the snappoint is hit, a snapshot appears in the Diagnostic Tools window. To open this window, choose **Debug > Windows > Show Diagnostic Tools**.
+
+   ![Open a snappoint](../debugger/media/snapshot-diagsession-window.png)
+
+1. Click the View Snapshot link to open the Time Travel recording in the code editor.
+  
+   You can execute every line of code recorded by the TTD by using the **Continue** and **Reverse Continue** buttons. Additionally the the Debug toolbar can be used to **Show Next Statement**, **Step Into**, **Step Over**, **Step Out**, **Step Back Into**, **Step Back Over**, **Step Back Out**.
+
+   ![Start Debugging](../debugger/media/time-travel-debugging-step-commands.png)
+
+   You can also use the **Locals**, **Watches**, and **Call Stack** windows, and also evaluate expressions.
+
+   ![Inspect snapshot data](../debugger/media/time-travel-debugging-start-debugging.png)
+
+    The website itself is still live and end users aren't impacted by any subsequent TTD activity. Only one snapshot is captured per snappoint by default: after a snapshot is captured the snappoint turns off. If you want to capture another snapshot at the snappoint, you can turn the snappoint back on by clicking **Update Collection**.
+
+**Need help?** See the [Troubleshooting and known issues](../debugger/debug-live-azure-apps-troubleshooting.md) and [FAQ for snapshot debugging](../debugger/debug-live-azure-apps-faq.md) pages.
+
+## Set a conditional snappoint
+
+If it is difficult to recreate a particular state in your app, consider whether the use of a conditional snappoint can help. Conditional snappoints help you avoid collecting a Time Travel recording until the app enters a desired state, such as when a variable has a particular value that you want to inspect. [You can set conditions using expressions, filters, or hit counts](../debugger/debug-live-azure-apps-troubleshooting.md).
+
+## Next steps
+
+In this tutorial, you've learned how to collect a Time Travel recording for Azure Virtual Machines. You may want to read more details about Snapshot Debugger.
+
+> [!div class="nextstepaction"]
+> [FAQ for snapshot debugging](../debugger/debug-live-azure-apps-faq.md)

docs/debugger/debug-live-azure-virtual-machines.md

@@ -29,11 +29,11 @@ In this tutorial, you will:
 
 ## Prerequisites
 
-* Snapshot Debugger for Azure Virtual Machines (VM) and Azure Virtual Machine Scale Sets (VMSS) is only available for Visual Studio 2019 Enterprise preview or higher with the **Azure development workload**. (Under the **Individual components** tab, you find it under **Debugging and testing** > **Snapshot debugger**.)
+* Snapshot Debugger for Azure Virtual Machines (VM) and Azure Virtual Machine Scale Sets is only available for Visual Studio 2019 Enterprise or higher with the **Azure development workload**. (Under the **Individual components** tab, you find it under **Debugging and testing** > **Snapshot debugger**.)
 
-    If it's not already installed, install [Visual Studio 2019 Enterprise preview](https://visualstudio.microsoft.com/vs/preview/).
+    If it's not already installed, install [Visual Studio 2019 Enterprise](https://visualstudio.microsoft.com/vs/).
 
-* Snapshot collection is available for the following Azure VM/VMSS web apps:
+* Snapshot collection is available for the following Azure Virtual Machines\Virtual Machine Scale Sets web apps:
   * ASP.NET applications running on .NET Framework 4.6.1 or later.
   * ASP.NET Core applications running on .NET Core 2.0 or later on Windows.
 
@@ -42,27 +42,27 @@ In this tutorial, you will:
 1. Open the project you would like to snapshot debug.
 
     > [!IMPORTANT]
-    > To snapshot debug, you need to open the *same version of source code* that is published to your Azure VM/VMSS service.
+    > To snapshot debug, you need to open the *same version of source code* that is published to your Azure Virtual Machine\Virtual Machine Scale Set service.
 
-1. Choose **Debug > Attach Snapshot Debugger...**. Select the Azure VM/VMSS your web app is deployed to and an Azure storage account, and then click **Attach**.
+1. Choose **Debug > Attach Snapshot Debugger...**. Select the Azure Virtual Machine\Virtual Machine Scale Set your web app is deployed to and an Azure storage account, and then click **Attach**.
 
       ![Launch the snapshot debugger from the Debug menu](../debugger/media/snapshot-debug-menu-attach.png)
 
       ![Select Azure Resource](../debugger/media/snapshot-select-azure-resource-vm.png) 
 
     > [!IMPORTANT]
     > The first time you select **Attach Snapshot Debugger** for your VM, IIS is automatically restarted.
-    > The first time you select **Attach Snapshot Debugger** for your VMSS, requires the manual upgrade of each instance of the VMSS.
+    > The first time you select **Attach Snapshot Debugger** for your Virtual Machine Scale Sets, requires the manual upgrade of each instance of the Virtual Machine Scale Sets.
 
     The metadata for the **Modules** will not initially be activated, navigate to the web app and the **Start Collection** button will become active. Visual Studio is now in snapshot debugging mode.
 
    ![Snapshot debugging mode](../debugger/media/snapshot-message.png)
 
     > [!NOTE]
     > The Application Insights site extension also supports Snapshot Debugging. If you encounter a "site extension out of date" error message, see [troubleshooting tips and known issues for snapshot debugging](../debugger/debug-live-azure-apps-troubleshooting.md) for upgrading details.
-    > For VMSS the user is required to manually upgrade the instances in their VMSS after attaching the Snapshot Debugger for the first time.
+    > For VMSS the user is required to manually upgrade the instances in their Virtual Machine Scale Sets after attaching the Snapshot Debugger for the first time.
 
-   The **Modules** window shows you when all the modules have loaded for the Azure VM/VMSS (choose **Debug > Windows > Modules** to open this window).
+   The **Modules** window shows you when all the modules have loaded for the Azure Virtual Machine\Virtual Machine Scale Set (choose **Debug > Windows > Modules** to open this window).
 
    ![Check the Modules window](../debugger/media/snapshot-modules.png)
 

docs/debugger/getting-started-with-the-debugger-cpp.md

@@ -40,7 +40,7 @@ You must have Visual Studio 2017 installed and the **Desktop development with C+
 
 ::: moniker-end
 
-If you haven't already installed Visual Studio, go to the [Visual Studio downloads](https://visualstudio.microsoft.com/downloads/) page to install it for free.
+If you haven't already installed Visual Studio, go to the [Visual Studio downloads](https://visualstudio.microsoft.com/downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=inline+link&utm_content=download+vs2019) page to install it for free.
 
 If you need to install the workload but already have Visual Studio, go to **Tools** > **Get Tools and Features...**, which opens the Visual Studio Installer. The Visual Studio Installer launches. Choose the **Desktop development with C++** workload, then choose **Modify**.