Merge pull request #6182 from ghogen/msbuild-issues

MSBuild issues

Author: GitHubber17

docs/msbuild/msbuild-best-practices.md

@@ -24,7 +24,7 @@ We recommend the following best practices for writing MSBuild scripts:
 </MyProperty>
 ```
 
-- Avoid wildcards when you select items. Instead, specify files explicitly. This makes it easier to track down errors that may occur when you add or delete files.
+- In general, avoid the use of wildcards when you select items. Instead, specify files explicitly. This is because in most project types, MSBuild expands wildcards at various times, such as when adding or removing items, which can lead to unexpected behavior. An exception to this is in .NET Core SDK-style projects, which do process wildcards correctly.
 
 ## See also
 

docs/msbuild/msbuild-project-file-schema-reference.md

@@ -48,9 +48,9 @@ The schema link in an MSBuild project file is not required in Visual Studio 2017
 |[PropertyGroup element (MSBuild)](../msbuild/propertygroup-element-msbuild.md)|*Property*|Condition|
 |[Sdk element (MSBuild)](../msbuild/sdk-element-msbuild.md)|--|Name<br /><br /> Version|
 |[Target element (MSBuild)](../msbuild/target-element-msbuild.md)|OnError<br /><br /> *Task*|AfterTargets<br /><br /> BeforeTargets<br /><br /> Condition<br /><br /> DependsOnTargets<br /><br /> Inputs<br /><br /> KeepDuplicateOutputs<br /><br /> Name<br /><br /> Outputs<br /><br /> Returns|
-|[Task element (MSBuild)](../msbuild/task-element-msbuild.md)|Output|Condition<br /><br /> ContinueOnError<br /><br /> *Parameter*|
-|[TaskBody element (MSBuild)](../msbuild/taskbody-element-msbuild.md)|*Data*|Evaluate|
-|[UsingTask element (MSBuild)](../msbuild/usingtask-element-msbuild.md)|ParameterGroup<br /><br /> TaskBody|AssemblyFile<br /><br /> AssemblyName<br /><br /> Condition<br /><br /> TaskFactory<br /><br /> TaskName|
+|[Task element of Target (MSBuild)](../msbuild/task-element-msbuild.md)|Output|Condition<br /><br /> ContinueOnError<br /><br /> *Parameter*|
+|[Task element of UsingTask (MSBuild)](../msbuild/taskbody-element-msbuild.md)|*Data*|Evaluate|
+|[UsingTask element (MSBuild)](../msbuild/usingtask-element-msbuild.md)|ParameterGroup<br /><br /> Task|AssemblyFile<br /><br /> AssemblyName<br /><br /> Condition<br /><br /> TaskFactory<br /><br /> TaskName|
 |[When element (MSBuild)](../msbuild/when-element-msbuild.md)|Choose<br /><br /> ItemGroup<br /><br /> PropertyGroup|Condition|
 
 ## See also

docs/msbuild/parameter-element.md

@@ -68,9 +68,9 @@ Contains information about a specific parameter for a task that is generated by
               <Parameter2 ParameterType="System.Int" Required="True" Output="False"/>
              ...
 </ParameterGroup>
-       <TaskBody Evaluate="true">
-      ... Task factory-specific data ...
-       </TaskBody>
+       <Task Evaluate="true">
+       ... Task factory-specific data ...
+       </Task>
 </UsingTask>
 ```
 

docs/msbuild/parametergroup-element.md

@@ -62,9 +62,9 @@ Contains an optional list of parameters that will be present on the task that is
               <Parameter2 ParameterType="System.Int" Required="True" Output="False"/>
              ...
 </ParameterGroup>
-       <TaskBody Evaluate="true">
-      ... Task factory-specific data ...
-       </TaskBody>
+       <Task Evaluate="true">
+       ... Task factory-specific data ...
+       </Task>
 </UsingTask>
 ```
 

docs/msbuild/task-element-msbuild.md

@@ -1,5 +1,5 @@
 ---
-title: Task Element (MSBuild) | Microsoft Docs
+title: Task Element of Target (MSBuild) | Microsoft Docs
 ms.date: 03/13/2017
 ms.topic: reference
 dev_langs:
@@ -17,7 +17,7 @@ manager: jillfra
 ms.workload:
 - multiple
 ---
-# Task element (MSBuild)
+# Task element of Target (MSBuild)
 
 Creates and executes an instance of an MSBuild task. The element name is determined by the name of the task being created.
 

docs/msbuild/taskbody-element-msbuild.md

@@ -1,5 +1,5 @@
 ---
-title: TaskBody Element (MSBuild) | Microsoft Docs
+title: Task Element of UsingTask (MSBuild) | Microsoft Docs
 ms.date: 03/13/2017
 ms.topic: reference
 dev_langs:
@@ -8,27 +8,27 @@ dev_langs:
 - C++
 - jsharp
 helpviewer_keywords:
-- TaskBody element [MSBuild]
-- <TaskBody> element [MSBuild]
+- Task element [MSBuild]
+- <Task> element [MSBuild]
 ms.assetid: 49d8741b-f1ea-4470-94fd-a1ac27341a6a
 author: ghogen
 ms.author: ghogen
 manager: jillfra
 ms.workload:
 - multiple
 ---
-# TaskBody element (MSBuild)
+# Task element of UsingTask (MSBuild)
 
 Contains the data that is passed to a `UsingTask` `TaskFactory`. For more information, see [UsingTask element (MSBuild)](../msbuild/usingtask-element-msbuild.md).
 
  \<Project>
  \<UsingTask>
- \<TaskBody>
+ \<Task>
 
 ## Syntax
 
 ```xml
-<TaskBody Evaluate="true/false" />
+<Task Evaluate="true/false" />
 ```
 
 ## Attributes and elements
@@ -45,7 +45,7 @@ Contains the data that is passed to a `UsingTask` `TaskFactory`. For more inform
 
 |Element|Description|
 |-------------|-----------------|
-|Data|The text between the `TaskBody` tags is sent verbatim to the `TaskFactory`.|
+|Data|The text between the `Task` tags is sent verbatim to the `TaskFactory`.|
 
 ### Parent elements
 
@@ -55,7 +55,7 @@ Contains the data that is passed to a `UsingTask` `TaskFactory`. For more inform
 
 ## Example
 
- The following example shows how to use the `TaskBody` element with an `Evaluate` attribute.
+ The following example shows how to use the `Task` element with an `Evaluate` attribute.
 
 ```xml
 <UsingTask TaskName="MyTask" AssemblyName="My.Assembly" TaskFactory="MyTaskFactory">
@@ -64,9 +64,9 @@ Contains the data that is passed to a `UsingTask` `TaskFactory`. For more inform
               <Parameter2 ParameterType="System.Int" Required="True" Output="False"/>
               ...
 </ParameterGroup>
-       <TaskBody Evaluate="true">
-      ... Task factory-specific data ...
-       </TaskBody>
+       <Task Evaluate="true">
+       ... Task factory-specific data ...
+       </Task>
 </UsingTask>
 ```
 

docs/msbuild/toc.yml

@@ -235,9 +235,9 @@
         href: sdk-element-msbuild.md
       - name: Target element
         href: target-element-msbuild.md
-      - name: Task element
+      - name: Task element of Target
         href: task-element-msbuild.md
-      - name: TaskBody element
+      - name: Task element of UsingTask
         href: taskbody-element-msbuild.md
       - name: UsingTask element
         href: usingtask-element-msbuild.md

docs/msbuild/usingtask-element-msbuild.md

@@ -48,7 +48,7 @@ Maps the task that is referenced in a [Task](../msbuild/task-element-msbuild.md)
 |---------------|-----------------|
 |`AssemblyName`|Either the `AssemblyName` attribute or the `AssemblyFile` attribute is required.<br /><br /> The name of the assembly to load. The `AssemblyName` attribute accepts strong-named assemblies, although strong-naming is not required. Using this attribute is equivalent to loading an assembly by using the <xref:System.Reflection.Assembly.Load%2A> method in .NET.<br /><br /> You cannot use this attribute if the `AssemblyFile` attribute is used.|
 |`AssemblyFile`|Either the `AssemblyName` or the `AssemblyFile` attribute is required.<br /><br /> The file path of the assembly. This attribute accepts full paths or relative paths. Relative paths are relative to the directory of the project file or targets file where the `UsingTask` element is declared. Using this attribute is equivalent to loading an assembly by using the <xref:System.Reflection.Assembly.LoadFrom%2A> method in .NET.<br /><br /> You cannot use this attribute if the `AssemblyName` attribute is used.|
-|`TaskFactory`|Optional attribute.<br /><br /> Specifies the class in the assembly that is responsible for generating instances of the specified `Task` name.  The user may also specify a `TaskBody` as a child element that the task factory receives and uses to generate the task. The contents of the `TaskBody` are specific to the task factory.|
+|`TaskFactory`|Optional attribute.<br /><br /> Specifies the class in the assembly that is responsible for generating instances of the specified `Task` name.  The user may also specify a `Task` as a child element that the task factory receives and uses to generate the task. The contents of the `Task` are specific to the task factory.|
 |`TaskName`|Required attribute.<br /><br /> The name of the task to reference from an assembly. If ambiguities are possible, this attribute should always specify full namespaces. If there are ambiguities, MSBuild chooses an arbitrary match, which could produce unexpected results.|
 |`Condition`|Optional attribute.<br /><br /> The condition to evaluate. For more information, see [Conditions](../msbuild/msbuild-conditions.md).|
 
@@ -85,9 +85,9 @@ Maps the task that is referenced in a [Task](../msbuild/task-element-msbuild.md)
               <Parameter2 ParameterType="System.Int" Required="True" Output="False"/>
               ...
 </ParameterGroup>
-       <TaskBody>
+       <Task>
       ... Task factory-specific data ...
-       </TaskBody>
+       </Task>
 </UsingTask>
 ```
 

docs/msbuild/walkthrough-creating-an-msbuild-project-file-from-scratch.md

@@ -148,8 +148,6 @@ Tasks in the Build target are executed sequentially. In this case, the Visual C#
 > ```xml
 > <Compile Include="*.cs" />
 > ```
->
-> However, we do not recommend the use of wildcard characters because it makes debugging and selective targeting more difficult if source files are added or deleted.
 
 ## Extend the path to include MSBuild