Skip to content

Commit d370e01

Browse files
authored
Merge pull request #5823 from MicrosoftDocs/master637348619715296011
For protected CLA branch, push strategy should use PR and merge to target branch method to work around git push error
2 parents 6538ee8 + d9f99b7 commit d370e01

13 files changed

+28
-17
lines changed

docker/tutorials/persist-your-data.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ As mentioned, you're going to use a **named volume**. Think of a named volume as
8181
docker volume create todo-db
8282
```
8383

84-
1. Stop the todo app container once again in the Dashboard (or with `docker rm -f <id>`), as it is still running without using the persistent volume.
84+
1. Stop the todo app container once again in the Docker view (or with `docker rm -f <id>`), as it is still running without using the persistent volume.
8585

8686
1. Start the todo app container, but add the `-v` flag to specify a volume mount. you will use the named volume and mount it to `/etc/todos`, which will capture all files created at the path.
8787

@@ -93,7 +93,7 @@ As mentioned, you're going to use a **named volume**. Think of a named volume as
9393

9494
![Items added to todo list](media/items-added.png)
9595

96-
1. Remove the container for the todo app. Use the Dashboard or `docker ps` to get the ID and then `docker rm -f <id>` to remove it.
96+
1. Remove the container for the todo app. Use the Docker view or `docker ps` to get the ID and then `docker rm -f <id>` to remove it.
9797

9898
1. Start a new container using the same command from above.
9999

docker/tutorials/share-your-app.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ If you look on the right-side of the page, you'll see a section named **Docker c
5858
docker push <username>/getting-started
5959
```
6060
61+
Instead of the command line, you can also right-click on the image tag in the **Images** section of the Docker view, and choose **Push...**, then choose **Connect registry...** and then **Docker Hub**.
62+
6163
## Run the image on a new instance
6264
6365
Now that your image has been built and pushed into a registry, try running the app on a brand new instance that has never seen this container image! To do this, you will use Play with Docker.

docker/tutorials/update-your-app.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ To remove a container, it first needs to be stopped. Once it has stopped, it can
7676
> [!TIP]
7777
> You can stop and remove a container in a single command by adding the "force" flag to the `docker rm` command. For example: `docker rm -f <the-container-id>`
7878

79-
### Remove a container using the Docker Dashboard
79+
### Remove a container using the Docker view
8080

8181
If you open the VS Code Extension, you can remove a container with two clicks! It's certainly much easier than having to look up the container ID and remove it.
8282
@@ -86,7 +86,7 @@ If you open the VS Code Extension, you can remove a container with two clicks! I
8686
8787
1. Confirm the removal and you're done!
8888

89-
![Docker Dashboard - removing a container](media/vs-removing-container.png)
89+
![Docker view - removing a container](media/vs-removing-container.png)
9090

9191
### Start the updated app container
9292

docker/tutorials/your-application.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ In order to build the application, you need to use a `Dockerfile`. A Dockerfile
5050
docker build -t getting-started .
5151
```
5252
53+
Alternatively, you can also right-click on the Dockerfile and choose **Build Image...** and then specify the tag at the prompt.
54+
5355
This command used the Dockerfile to build a new container image. You might have noticed that a lot of "layers" were downloaded. This is because you instructed the builder that you wanted to start from the `node:12-alpine` image. But, since you didn't have that on your machine, that image needed to be downloaded.
5456

5557
After the image was downloaded, you copied in your application and used `yarn` to install your application's dependencies. The `CMD` directive specifies the default command to run when starting a container from this image.

docs/ai/overview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ Browse samples in the [Samples repository](https://github.com/Microsoft/samples-
3434
To learn even more about Visual Studio Tools for AI, including system requirements and support options, see the [About Visual Studio Tools for AI](about-ai-tools.md) page.
3535

3636
## See also
37-
[Visual Studio extensibility](/visualstudio/extensibility/?view=vs-2017)
37+
[Visual Studio extensibility](../extensibility/index.yml?view=vs-2017)

docs/code-quality/use-roslyn-analyzers.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ The following screenshot shows the same three violations as they appear in the E
7171

7272
![Error, warning, and info violation in Error List](media/diagnostics-severities-in-error-list.png)
7373

74+
### 'Hidden' severity versus 'None' severity
75+
76+
`Hidden` severity rules that are enabled by default are different from disabled or `None` severity rules in couple of ways.
77+
78+
- If any code fix has been registered for a `Hidden` severity rule, then the fix is offered as a light bulb code refactoring action in Visual Studio, even though the hidden diagnostic is not visible to the user. This is not the case for disabled `None` severity rules.
79+
- `Hidden` severity rules can be bulk configured by entries that [set rule severity of multiple analyzer rules at once in an EditorConfig file](#set-rule-severity-of-multiple-analyzer-rules-at-once-in-an-editorconfig-file). `None` severity rules cannot be configured this way. Instead, they must be configured through entries that [set rule severity in an EditorConfig file for each rule ID](#set-rule-severity-in-an-editorconfig-file).
80+
7481
::: moniker range=">=vs-2019"
7582

7683
### Set rule severity in an EditorConfig file

docs/containers/container-tools-react.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ You can now pull the container from the registry to any host capable of running
240240

241241
## Additional resources
242242

243-
* [Container development with Visual Studio](/visualstudio/containers)
243+
* [Container development with Visual Studio](./index.yml)
244244
* [Troubleshoot Visual Studio development with Docker](troubleshooting-docker-errors.md)
245245
* [Visual Studio Container Tools GitHub repository](https://github.com/Microsoft/DockerTools)
246246

@@ -249,4 +249,4 @@ You can now pull the container from the registry to any host capable of running
249249
::: moniker-end
250250
::: moniker range=">=vs-2019"
251251
[0]:media/hosting-web-apps-in-docker/vs-acr-provisioning-dialog-2019.png
252-
::: moniker-end
252+
::: moniker-end

docs/containers/container-tools.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ ms.topic: include
2323

2424
## Additional resources
2525

26-
* [Container development with Visual Studio](/visualstudio/containers)
26+
* [Container development with Visual Studio](./index.yml)
2727
* [Troubleshoot Visual Studio development with Docker](troubleshooting-docker-errors.md)
28-
* [Visual Studio Container Tools GitHub repository](https://github.com/Microsoft/DockerTools)
28+
* [Visual Studio Container Tools GitHub repository](https://github.com/Microsoft/DockerTools)

docs/containers/deploy-docker-hub.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ Set up continuous integration and delivery (CI/CD) with [Azure Pipelines](/azure
5151
## See also
5252

5353
[Deploy to Azure App Service](deploy-app-service.md)
54-
[Visual Studio Container Tools](/visualstudio/containers/).
54+
[Visual Studio Container Tools](./index.yml).

docs/containers/edit-and-refresh.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ Get more details by reading [How Visual Studio builds containerized apps](contai
164164

165165
## More about Docker with Visual Studio, Windows, and Azure
166166

167-
* Learn more about [container development with Visual Studio](/visualstudio/containers).
167+
* Learn more about [container development with Visual Studio](./index.yml).
168168
* To build and deploy a Docker container, see [Docker integration for Azure Pipelines](https://marketplace.visualstudio.com/items?itemName=ms-vscs-rm.docker).
169169
* For an index of Windows Server and Nano Server articles, see [Windows container information](/virtualization/windowscontainers/).
170-
* Learn about [Azure Kubernetes Service](https://azure.microsoft.com/services/kubernetes-service/) and review the [Azure Kubernetes Service documentation](/azure/aks).
170+
* Learn about [Azure Kubernetes Service](https://azure.microsoft.com/services/kubernetes-service/) and review the [Azure Kubernetes Service documentation](/azure/aks).

docs/containers/index.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ landingContent:
3030
- text: Docker in Visual Studio
3131
url: container-tools.md
3232
- text: Running build tools in a container
33-
url: /visualstudio/install/build-tools-container
33+
url: ../install/build-tools-container.md
3434
- text: Visual Studio Tools for Kubernetes
3535
url: tutorial-kubernetes-tools.md
3636

docs/containers/tutorial-multicontainer.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Add a project to the same solution and call it *MyWebAPI*. Select **API** as the
8080
```
8181

8282
> [!NOTE]
83-
> In real-world code, you shouldn't dispose `HttpClient` after every request. For best practices, see [Use HttpClientFactory to implement resilient HTTP requests](https://docs.microsoft.com/dotnet/architecture/microservices/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests).
83+
> In real-world code, you shouldn't dispose `HttpClient` after every request. For best practices, see [Use HttpClientFactory to implement resilient HTTP requests](/dotnet/architecture/microservices/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests).
8484
8585
For .NET Core 3.1 in Visual Studio 2019 or later, the Web API template uses a WeatherForecast API, so uncomment that line and comment out the line for ASP.NET 2.x.
8686

@@ -189,4 +189,4 @@ Look at the options for deploying your [containers to Azure](/azure/containers).
189189
## See also
190190
191191
[Docker Compose](https://docs.docker.com/compose/)
192-
[Container Tools](/visualstudio/containers/)
192+
[Container Tools](./index.yml)

docs/containers/view-and-diagnose-containers.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,6 @@ Learn more about the Container Tools available in Visual Studio by reading the [
104104

105105
## See also
106106

107-
[Container Development in Visual Studio](/visualstudio/containers)
107+
[Container Development in Visual Studio](./index.yml)
108108

109-
[Extensions Marketplace for Visual Studio](https://marketplace.visualstudio.com/)
109+
[Extensions Marketplace for Visual Studio](https://marketplace.visualstudio.com/)

0 commit comments

Comments
 (0)