Merge pull request #6 from MicrosoftDocs/master

Updating my fork with the latest from visualstudio-docs-pr

Author: jmatthiesen

.markdownlint.json

@@ -2,26 +2,17 @@
     "default": true,
     "MD001": false,
     "MD002": false,
-    "MD003": false,
     "MD004": false,
-    "MD005": false,
-    "MD006": false,
     "MD007": false,
     "MD009": false,
     "MD011": false,
-    "MD012": false,
     "MD013": false,
-    "MD019": false,
-    "MD020": false,
     "MD022": false,
     "MD024": false,
     "MD025": false,
     "MD026": false,
-    "MD027": false,
     "MD028": false,
     "MD029": false,
-    "MD030": false,
-    "MD031": false,
     "MD032": false,
     "MD033": {
         "allowed_elements": [
@@ -40,6 +31,5 @@
     "MD036": false,
     "MD040": false,
     "MD041": false,
-    "MD042": false,
     "MD045": false
 }

.openpublishing.redirection.json

@@ -1280,6 +1280,11 @@
             "redirect_url": "/visualstudio/ide/class-designer/designing-and-viewing-classes-and-types",
             "redirect_document_id": false
         },
+        {
+            "source_path": "docs/ide/code-styles-and-quick-actions.md",
+            "redirect_url": "/visualstudio/ide/code-styles-and-code-cleanup",
+            "redirect_document_id": false
+        },
         {
             "source_path": "docs/ide/command-line-arguments-for-the-help-content-manager.md",
             "redirect_url": "/visualstudio/help-viewer/command-line-arguments",
@@ -1695,6 +1700,11 @@
             "redirect_url": "/visualstudio/ide/reference/generate-xml-documentation-comments",
             "redirect_document_id": false
         },
+        {
+            "source_path": "docs/ide/talk-to-us.md",
+            "redirect_url": "/visualstudio/ide/feedback-options",
+            "redirect_document_id": false
+        },
         {
             "source_path": "docs/ide/targeting-a-specific-dotnet-framework-version.md",
             "redirect_url": "/visualstudio/ide/visual-studio-multi-targeting-overview",
@@ -2040,6 +2050,11 @@
             "redirect_url": "/visualstudio/modeling/create-uml-modeling-projects-and-diagrams",
             "redirect_document_id": false
         },
+        {
+            "source_path": "docs/modeling/nesting-shapes.md",
+            "redirect_url": "/visualstudio/modeling/customizing-presentation-on-the-diagram",
+            "redirect_document_id": false
+        },
         {
             "source_path": "docs/modeling/open-a-uml-model-by-using-the-visual-studio-api.md",
             "redirect_url": "/visualstudio/modeling/create-uml-modeling-projects-and-diagrams",
@@ -2205,10 +2220,10 @@
             "redirect_url": "/visualstudio/port-migrate-and-upgrade-visual-studio-projects",
             "redirect_document_id": false
         },
-        { 
-            "source_path": "docs/porting/port-migrate-upgrade-visual-studio-projects-2019.md", 
-            "redirect_url": "/visualstudio/porting/port-migrate-and-upgrade-visual-studio-projects", 
-            "redirect_document_id": false 
+        {
+            "source_path": "docs/porting/port-migrate-upgrade-visual-studio-projects-2019.md",
+            "redirect_url": "/visualstudio/porting/port-migrate-and-upgrade-visual-studio-projects",
+            "redirect_document_id": false
         },
         {
             "source_path": "docs/profiling/analyze-cpu-usage-in-a-windows-universal-app.md",
@@ -7339,6 +7354,36 @@
             "source_path": "subscriptions/vscloud-renewals.md",
             "redirect_url": "/visualstudio/subscriptions/vscloud-overview",
             "redirect_document_id": false
+        },
+        {
+            "source_path": "docs/containers/docker-tools.md",
+            "redirect_url": "/visualstudio/containers/container-tools",
+            "redirect_document_id": true
+        },
+        {
+            "source_path": "docs/containers/visual-studio-tools-for-docker.md",
+            "redirect_url": "/visualstudio/containers/overview",
+            "redirect_document_id": true
+        },
+        {
+            "source_path": "docs/containers/vs-azure-tools-docker-edit-and-refresh.md",
+            "redirect_url": "/visualstudio/containers/edit-and-refresh",
+            "redirect_document_id": true
+        },
+        {
+            "source_path": "docs/containers/vs-azure-tools-docker-hosting-web-apps-in-docker.md",
+            "redirect_url": "/visualstudio/containers/hosting-web-apps-in-docker",
+            "redirect_document_id": true
+        },
+        {
+            "source_path": "docs/containers/docker-deploy-app-service.md",
+            "redirect_url": "/visualstudio/containers/deploy-app-service",
+            "redirect_document_id": true
+        },
+        {
+            "source_path": "docs/containers/vs-azure-tools-docker-troubleshooting-docker-errors.md",
+            "redirect_url": "/visualstudio/containers/troubleshooting-docker-errors",
+            "redirect_document_id": true
         }
     ]
 }

docs/ai/installation.md

@@ -81,6 +81,7 @@ Deep learning frameworks rely on pip for their own installation.
 Then, we need to verify whether Python 3.5 is installed correctly, and upgrade pip to the latest version by executing the following commands in a terminal:
 
 - **Windows**
+
     ```cmd
     C:\Users\test>python -V
     Python 3.5.4
@@ -92,6 +93,7 @@ Then, we need to verify whether Python 3.5 is installed correctly, and upgrade p
     ```
 
 - **macOS**
+
     ```bash
     MyMac:~ test$ python3.5 -V
     Python 3.5.4
@@ -153,10 +155,13 @@ Visit [here](https://caffe2.ai/docs/getting-started.html) to build from source c
 To install MXNet, run the following command in a terminal:
 
 - With GPU
+
     ```bash
     pip3.5 install mxnet-cu80==0.12.0
     ```
+
 - Without GPU
+
     ```bash
     pip3.5 install mxnet==0.12.0
     ```

docs/azure/includes/storage-try-azure-tools.md

@@ -5,4 +5,3 @@
 > [Microsoft Azure Storage Explorer](/azure/vs-azure-tools-storage-manage-with-storage-explorer) is a free, standalone app from Microsoft. You can use it to work visually with Azure Storage data on Windows, macOS, and Linux.
 > 
 > 
-

docs/azure/vs-azure-tools-configure-roles-for-cloud-service.md

@@ -250,7 +250,7 @@ The following code shows an example of how to write a text file to local storage
 
 To view the file created by the code in the previous section, follow these steps:
 
-1.  In the Windows notification area, right-click the Azure icon, and, from the context menu, select **Show Compute Emulator UI**.
+1. In the Windows notification area, right-click the Azure icon, and, from the context menu, select **Show Compute Emulator UI**.
 
     ![Show Azure compute emulator](./media/vs-azure-tools-configure-roles-for-cloud-service/show-compute-emulator.png)
 

docs/azure/vs-azure-tools-diagnostics-for-cloud-services-and-virtual-machines.md

@@ -148,6 +148,7 @@ If you're using Azure SDK 2.5 and want to specify a custom data source, you can
    <DataSource name="CustomDataSource!*" />
 </WindowsEventLog>
 ```
+
 ### Performance counters
 Performance counter information can help you locate system bottlenecks and fine-tune system and application performance. For more information, see [Create and use performance counters in an Azure application](https://msdn.microsoft.com/library/azure/hh411542.aspx). To capture performance counters, select the **Enable transfer of Performance Counters** check box. To increase or decrease the interval between the transfer of event logs to your storage account, change the **Transfer Period (min)** value. Select the check boxes for the performance counters that you want to track.
 

docs/azure/vs-azure-tools-multiple-services-project-configurations.md

@@ -23,7 +23,6 @@ Configuration settings are managed and modified in Visual Studio using property
 
 For information about the underlying schemas for the service definition and service configuration files, see the [.csdef XML Schema](/azure/cloud-services/schema-csdef-file) and [.cscfg XML Schema](/azure/cloud-services/schema-cscfg-file) articles. For more information about service configuration, see [How to Configure Cloud Services](/azure/cloud-services/cloud-services-how-to-configure-portal).
 
-
 ## Configuration page
 
 ### Service Configuration

docs/azure/vs-azure-tools-optimizing-azure-code-in-visual-studio.md

@@ -209,6 +209,7 @@ while (true)
    }
 }
 ```
+
 ## Consider using asynchronous Service Bus methods
 ### ID
 AP2003

docs/azure/vs-azure-tools-publish-webapplicationwebsite-windows-powershell-script.md

@@ -22,7 +22,6 @@ Publishes a web project to an Azure website. The script creates the required res
     -SendHostMessagesToOutput
     -Verbose
 
-
 ## Configuration
 The path to the JSON configuration file that describes the details of the deployment.
 

docs/azure/vs-azure-tools-resource-groups-ci.md

@@ -166,6 +166,7 @@ The following procedures walk you through the steps necessary to configure conti
      ```
      -_artifactsLocation $(artifactsLocation) -_artifactsLocationSasToken (ConvertTo-SecureString -String "$(artifactsLocationSasToken)" -AsPlainText -Force)
      ```
+
      ![Configure Azure Resource Group Deployment Task](media/vs-azure-tools-resource-groups-ci-in-vsts/walkthrough18.png)
 7. After you’ve added all the required items, save the build pipeline and choose **Queue new build** at the top.
 

docs/code-quality/C26401.md

@@ -16,5 +16,4 @@ ms.workload:
 # C26401 DONT_DELETE_NON_OWNER
 This check detects places where moving to `owner<T>` can be a good option for the first stage of refactoring. Like C26400 it enforces rules I.11 and R.3, but focuses on the "release" portion of the pointer lifetime. It warns on any call to operator `delete` if its target is neither an `owner<T>` nor an implicitly assumed owner. For more information, see [C26400](c26400.md) regarding the auto declarations. This does include expressions that refer to global variables, formals, and so on.
 
-
 Warnings C26400 and C26401 always occur with [C26409](c26409.md), but they are more appropriate for scenarios where immediate migration to smart pointers is not feasible. In such cases the `owner<T>` concept can be adopted first and C26409 may be temporarily suppressed.

docs/code-quality/C26402.md

@@ -16,5 +16,4 @@ ms.workload:
 # C26401 DONT_DELETE_NON_OWNER
 This check detects places where moving to `owner<T>` can be a good option for the first stage of refactoring. Like C26400 it enforces rules I.11 and R.3, but focuses on the "release" portion of the pointer lifetime. It warns on any call to operator `delete` if its target is neither an `owner<T>` nor an implicitly assumed owner. For more information, see [C26400](c26400.md) regarding the auto declarations. This does include expressions that refer to global variables, formals, and so on.
 
-
 Warnings C26400 and C26401 always occur with [C26409](c26409.md), but they are more appropriate for scenarios where immediate migration to smart pointers is not feasible. In such cases the `owner<T>` concept can be adopted first and C26409 may be temporarily suppressed.

docs/code-quality/C26404.md

@@ -18,6 +18,7 @@ Once owner pointer releases or transfers its resource, it gets into an "invalid"
 Deleting such a pointer may lead to immediate memory corruption due to double delete, or to an access violation when the deleted resource is accessed from another owner pointer.
 
 ## Example 1: Deleting an owner after transferring its value
+
 ```cpp
 gsl::owner<State*> validState = nullptr;
 gsl::owner<State*> state = ReadState();
@@ -27,6 +28,7 @@ if (!IsValid(state))
 ```
 
 ## Example 2: Deleting an uninitialized owner
+
 ```cpp
 gsl::owner<Message*> message;
 if (popLast)

docs/code-quality/C26405.md

@@ -17,6 +17,7 @@ ms.workload:
 If an owner pointer already points to a valid memory buffer, it must not be assigned to another value without releasing its current resource first. Such assignment may lead to a resource leak even if the resource address is copied into some raw pointer (because raw pointers shouldn’t release resources).
 
 ## Example 1: Overwriting an owner in a loop
+
 ```cpp
 gsl::owner<Shape*> shape = nullptr;
 while (shape = NextShape()) // C26405

docs/code-quality/C26406.md

@@ -17,6 +17,7 @@ ms.workload:
 Owners are initialized from allocations or from other owners. Assigning a value from a raw pointer to an owner pointer is not allowed. Raw pointers don’t guarantee ownership transfer; there is still may be an original owner which holds the resource and will attempt to release it. Note that assigning a value from owner to a raw pointer is fine; raw pointers are valid clients to access resources, but not to manage them.
 
 ## Example 1:  Using address of object
+
 ```cpp
 gsl::owner<Socket*> socket = defaultSocket ? &defaultSocket : new Socket(); // C26406
 ```

docs/code-quality/C26407.md

@@ -23,26 +23,31 @@ To avoid unnecessary use of pointers we try to detect common patterns of local a
 - The pattern is detected only for local variables, so we don’t warn on cases where an allocation is assigned to, say, a global variable and then deleted in the same function.
 
 ## Example 1: Unnecessary object allocation on heap
+
 ```cpp
 auto tracer = new Tracer();
 ScanObjects(tracer);
 delete tracer;  // C26407
 ```
 
 ## Example 2: Unnecessary object allocation on heap (fixed with local object)
+
 ```cpp
 Tracer tracer;  // OK
 ScanObjects(&tracer);
 ```
 
 ## Example 3: Unnecessary buffer allocation on heap
+
 ```cpp
 auto value = new char[maxValueSize];
 if (ReadSetting(name, value, maxValueSize))
     CheckValue(value);
 delete[] value; // C26407
 ```
+
 ## Example 4: Unnecessary buffer allocation on the heap (fixed with container)
+
 ```cpp
 auto value = std::vector<char>(maxValueSize); // OK
 if (ReadSetting(name, value.data(), maxValueSize))

docs/code-quality/C26410.md

@@ -21,6 +21,7 @@ Generally, references to const unique pointer are meaningless. They can safely b
 - Template code may produce a lot of noise. Keep in mind that templates can be instantiated with various type parameters with different levels of indirection, including references. Some warnings may not be obvious and fixes may require some rework of templates (for example, explicit removal of reference indirection). If template code is intentionally generic, the warning can be suppressed.
 
 ## Example 1: Unnecessary reference
+
 ```cpp
 std::vector<std::unique_ptr<Tree>> roots = GetRoots();
 std::for_each(

docs/code-quality/C26416.md

@@ -22,10 +22,10 @@ R.34: Take a shared_ptr\<widget> parameter to express that a function is part ow
 Passing a shared pointer by rvalue reference is usually unnecessary. Unless it is an implementation of move semantics for a shared pointer type itself, shared pointer objects can be safely passed by value. Using rvalue reference may be also an indication that unique pointer is more appropriate since it clearly transfers unique ownership from caller to callee.
 
 ## Remarks
--  This check recognizes std::shared_pointer and user-defined types which are likely to behave like shared pointers. The following traits are expected for user-defined shared pointers:
--  overloaded dereference or member access operators (public and non-deleted);
--  copy constructor or copy assignment operator (public and non-deleted);
--  public destructor which is neither deleted nor defaulted. Empty destructors are still counted as user-defined.
+- This check recognizes std::shared_pointer and user-defined types which are likely to behave like shared pointers. The following traits are expected for user-defined shared pointers:
+- overloaded dereference or member access operators (public and non-deleted);
+- copy constructor or copy assignment operator (public and non-deleted);
+- public destructor which is neither deleted nor defaulted. Empty destructors are still counted as user-defined.
 
 ## Example
 questionable constructor optimization

docs/code-quality/C26417.md

@@ -22,13 +22,13 @@ R.35: Take a shared_ptr\<widget>& parameter to express that a function might res
 Passing shared pointers by reference may be useful in scenarios where callee code updates target of the smart pointer object and its caller expects to see such update. Using a reference solely to reduce costs of passing a shared pointer is questionable. If callee code only accesses target object and never manages its lifetime, it is safer to pass raw pointer or reference, rather than to expose resource management details.
 
 ## Remarks
--  This check recognizes std::shared_pointer and user-defined types which are likely to behave like shared pointers. The following traits are expected for user-defined shared pointers:
--  overloaded dereference or member access operators (public and non-deleted);
--  copy constructor or copy assignment operator (public and non-deleted);
--  public destructor which is neither deleted nor defaulted. Empty destructors are still counted as user-defined.
--  The action of resetting or reassigning is interpreted in a more generic way:
--  any call to a non-constant function on a shared pointer can potentially reset the pointer;
--  any call to a function which accepts a reference to a non-constant shared pointer can potentially reset or reassign that pointer.
+- This check recognizes std::shared_pointer and user-defined types which are likely to behave like shared pointers. The following traits are expected for user-defined shared pointers:
+- overloaded dereference or member access operators (public and non-deleted);
+- copy constructor or copy assignment operator (public and non-deleted);
+- public destructor which is neither deleted nor defaulted. Empty destructors are still counted as user-defined.
+- The action of resetting or reassigning is interpreted in a more generic way:
+- any call to a non-constant function on a shared pointer can potentially reset the pointer;
+- any call to a function which accepts a reference to a non-constant shared pointer can potentially reset or reassign that pointer.
 
 ## Example
 unnecessary interface complication

docs/code-quality/C26418.md

@@ -22,10 +22,10 @@ R.36: Take a const shared_ptr\<widget>& parameter to express that it might retai
 If shared pointer parameter is passed by value or reference to a constant object it is expected that function will take control of its target object’s lifetime without affecting of the caller. The code should either copy or move the shared pointer parameter to another shared pointer object or pass it further to other code by invoking functions which accept shared pointers. If this is not the case, then plain pointer or reference may be feasible.
 
 ## Remarks
--  This check recognizes std::shared_pointer and user-defined types which are likely to behave like shared pointers. The following traits are expected for user-defined shared pointers:
--  overloaded dereference or member access operators (public and non-deleted);
--  copy constructor or copy assignment operator (public and non-deleted);
--  public destructor which is neither deleted nor defaulted. Empty destructors are still counted as user-defined.
+- This check recognizes std::shared_pointer and user-defined types which are likely to behave like shared pointers. The following traits are expected for user-defined shared pointers:
+- overloaded dereference or member access operators (public and non-deleted);
+- copy constructor or copy assignment operator (public and non-deleted);
+- public destructor which is neither deleted nor defaulted. Empty destructors are still counted as user-defined.
 
 ## Example
 unnecessary interface complication

docs/code-quality/C26432.md

@@ -23,11 +23,11 @@ Special operations like constructors are assumed to alter behavior of types so t
 
 ## Remarks
 - This check implements "the rule of five" which treats the following operations as special:
-  -  copy constructors;
-  -  move constructors;
-  -  copy assignment operators;
-  -  move assignment operators;
-  -  destructors;
-  -  The rule doesn’t check if operations are defined in the same way, i.e. it is okay to mix deleted and defaulted operations with explicitly defined, but they all must be specified somehow if any of them appears.
-  -  Access levels are not important and can also be mixed.
-  -  The warning flags the first non-static function definition of a type, once per type.
+  - copy constructors;
+  - move constructors;
+  - copy assignment operators;
+  - move assignment operators;
+  - destructors;
+  - The rule doesn’t check if operations are defined in the same way, i.e. it is okay to mix deleted and defaulted operations with explicitly defined, but they all must be specified somehow if any of them appears.
+  - Access levels are not important and can also be mixed.
+  - The warning flags the first non-static function definition of a type, once per type.