Skip to content

(GitHub Toggle Expanders) Shift+Click (toggle all expanders within a date block) not working in repo commit pages #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darkred opened this issue Dec 18, 2020 · 2 comments

Comments

@darkred
Copy link
Collaborator

darkred commented Dec 18, 2020

Hi there @Mottie .

I've tried 'GitHub Toggle Expanders' in repository commit pages
and unfortunately Shift + Click (toggle all expanders within a date block, e.g. a commit in Dec 17, 2020) doesn't toggle any other expanders but the current one.
There's no error in Console.
(Ctrl + Shift + Click (toggle all expanders on the page) works fine).

Example pages:
https://github.com/mirror/jdownloader/commits/master
https://github.com/torvalds/linux/commits/master

Tested with Tampermonkey/Violentmonkey in Chrome/Firefox.


Also, in the script wiki it says:

  • Toggle expanders ()
    • Use Shift + Click on an expander to toggle all expanders within a date block (New behavior in v2.0.0)
    • Use (Ctrl or ) + Shift + Click on an expander to toggle all expanders on the page (New behavior in v2.0.0).

The accompanying GIF shows that Shift+Click expands all expanders in the page, not those within a date block.
So, the GIF depicts the pre v2.0.0 behavior. Could you please also update it?

@Mottie Mottie closed this as completed in 16d0391 Dec 19, 2020
@Mottie
Copy link
Owner

Mottie commented Dec 19, 2020

Thanks! It's fixed now.

@darkred
Copy link
Collaborator Author

darkred commented Dec 19, 2020

Thanks a lot for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants