Bug#35157953 MySQL Router stops accepting connections - 8.0.32

Post-push fix:
Remove the dependency connection -> destination the initial patch
introduced to allow cleaner reuse in MCMD component.

Change-Id: Ie10bc4a13f077c3eddf3da2b9867ffa0dee76a6c

Author: Andrzej Religa

router/src/routing/src/CMakeLists.txt

@@ -38,6 +38,7 @@ ADD_DEPENDENCIES(sql_lexer GenServerSource)
 ADD_LIBRARY(routing SHARED
   mysql_routing.cc
   destination.cc
+  destination_error.cc
   dest_metadata_cache.cc
   dest_first_available.cc
   dest_next_available.cc

router/src/routing/src/connection.h

@@ -34,6 +34,7 @@
 #include "basic_protocol_splicer.h"
 #include "context.h"
 #include "destination.h"  // RouteDestination
+#include "destination_error.h"
 #include "mysql/harness/net_ts/io_context.h"
 #include "mysql/harness/net_ts/timer.h"
 #include "mysql/harness/stdx/monitor.h"

router/src/routing/src/destination.cc

@@ -29,6 +29,7 @@
 #include <stdexcept>  // out_of_range
 #include <system_error>
 
+#include "destination_error.h"
 #include "mysqlrouter/routing.h"
 #include "tcp_address.h"
 
@@ -157,27 +158,3 @@ std::optional<Destinations> RouteDestination::refresh_destinations(
     const Destinations &) {
   return std::nullopt;
 }
-
-const std::error_category &destinations_error_category() noexcept {
-  class destinations_category_impl : public std::error_category {
-   public:
-    const char *name() const noexcept override { return "destinations"; }
-    std::string message(int ev) const override {
-      switch (static_cast<DestinationsErrc>(ev)) {
-        case DestinationsErrc::kNotSet:
-          return "not set";
-        case DestinationsErrc::kNoDestinations:
-          return "no destinations";
-        default:
-          return "(unrecognized error)";
-      }
-    }
-  };
-
-  static destinations_category_impl instance;
-  return instance;
-}
-
-std::error_code make_error_code(DestinationsErrc e) {
-  return {static_cast<int>(e), destinations_error_category()};
-}

router/src/routing/src/destination.h

@@ -322,16 +322,4 @@ class RouteDestination : public DestinationNodesStateNotifier {
   Protocol::Type protocol_;
 };
 
-enum class DestinationsErrc {
-  kNotSet = 1,
-  kNoDestinations = 2,
-};
-
-namespace std {
-template <>
-struct is_error_code_enum<DestinationsErrc> : true_type {};
-}  // namespace std
-
-std::error_code make_error_code(DestinationsErrc);
-
 #endif  // ROUTING_DESTINATION_INCLUDED

router/src/routing/src/destination_error.cc

@@ -0,0 +1,51 @@
+/*
+  Copyright (c) 2023, Oracle and/or its affiliates.
+
+  This program is free software; you can redistribute it and/or modify
+  it under the terms of the GNU General Public License, version 2.0,
+  as published by the Free Software Foundation.
+
+  This program is also distributed with certain software (including
+  but not limited to OpenSSL) that is licensed under separate terms,
+  as designated in a particular file or component or in included license
+  documentation.  The authors of MySQL hereby grant you an additional
+  permission to link the program and your derivative works with the
+  separately licensed software that they have included with MySQL.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program; if not, write to the Free Software
+  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+*/
+
+#include "destination_error.h"
+
+#include <string>
+
+const std::error_category &destinations_error_category() noexcept {
+  class destinations_category_impl : public std::error_category {
+   public:
+    const char *name() const noexcept override { return "destinations"; }
+    std::string message(int ev) const override {
+      switch (static_cast<DestinationsErrc>(ev)) {
+        case DestinationsErrc::kNotSet:
+          return "not set";
+        case DestinationsErrc::kNoDestinations:
+          return "no destinations";
+        default:
+          return "(unrecognized error)";
+      }
+    }
+  };
+
+  static destinations_category_impl instance;
+  return instance;
+}
+
+std::error_code make_error_code(DestinationsErrc e) {
+  return {static_cast<int>(e), destinations_error_category()};
+}

router/src/routing/src/destination_error.h

@@ -0,0 +1,43 @@
+/*
+  Copyright (c) 2023, Oracle and/or its affiliates.
+
+  This program is free software; you can redistribute it and/or modify
+  it under the terms of the GNU General Public License, version 2.0,
+  as published by the Free Software Foundation.
+
+  This program is also distributed with certain software (including
+  but not limited to OpenSSL) that is licensed under separate terms,
+  as designated in a particular file or component or in included license
+  documentation.  The authors of MySQL hereby grant you an additional
+  permission to link the program and your derivative works with the
+  separately licensed software that they have included with MySQL.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program; if not, write to the Free Software
+  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+*/
+
+#ifndef ROUTING_DESTINATION_ERROR_INCLUDED
+#define ROUTING_DESTINATION_ERROR_INCLUDED
+
+#include <system_error>
+#include <vector>
+
+enum class DestinationsErrc {
+  kNotSet = 1,
+  kNoDestinations = 2,
+};
+
+namespace std {
+template <>
+struct is_error_code_enum<DestinationsErrc> : true_type {};
+}  // namespace std
+
+std::error_code make_error_code(DestinationsErrc);
+
+#endif  // ROUTING_DESTINATION_ERROR_INCLUDED