Skip to content

Commit 1da74d1

Browse files
committed
[TASK] Drop getLineNo() from the Renderable interface
The concept of being able to get rendered is logically independent from having a position in the input stream. Hence, both concepts should not be intermingled in the `Renderable` interface. (We might want to add a dedicated interface for classes that are linked to specific points in the input stream later, though.)
1 parent 7842530 commit 1da74d1

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Please also have a look at our
3838

3939
### Removed
4040

41+
- Drop `getLineNo()` from the `Renderable` interface (#1038)
4142
- Remove `OutputFormat::level()` (#874)
4243
- Remove expansion of shorthand properties (#838)
4344
- Remove `Parser::setCharset/getCharset` (#808)

src/Renderable.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,4 @@ interface Renderable
1212
public function __toString(): string;
1313

1414
public function render(OutputFormat $outputFormat): string;
15-
16-
/**
17-
* @return int<0, max>
18-
*/
19-
public function getLineNo(): int;
2015
}

0 commit comments

Comments
 (0)