[TASK] Raise PHPStan to level 3

Author: oliverklee

config/phpstan-baseline.neon

@@ -12,6 +12,18 @@ parameters:
 			count: 1
 			path: ../src/CSSList/AtRuleBlockList.php
 
+		-
+			message: '#^Parameter &\$result by\-ref type of method Sabberworm\\CSS\\CSSList\\CSSBlockList\:\:allSelectors\(\) expects array\<int, Sabberworm\\CSS\\Property\\Selector\>, array\<int, Sabberworm\\CSS\\Property\\Selector\|string\> given\.$#'
+			identifier: parameterByRef.type
+			count: 2
+			path: ../src/CSSList/CSSBlockList.php
+
+		-
+			message: '#^Parameter &\$result by\-ref type of method Sabberworm\\CSS\\CSSList\\CSSBlockList\:\:allValues\(\) expects array\<int, Sabberworm\\CSS\\Value\\Value\>, array\<int, Sabberworm\\CSS\\CSSList\\CSSList\|Sabberworm\\CSS\\Value\\Value\> given\.$#'
+			identifier: parameterByRef.type
+			count: 1
+			path: ../src/CSSList/CSSBlockList.php
+
 		-
 			message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:safely\(\)\.$#'
 			identifier: method.notFound
@@ -54,6 +66,24 @@ parameters:
 			count: 1
 			path: ../src/CSSList/KeyFrame.php
 
+		-
+			message: '#^Method Sabberworm\\CSS\\OutputFormat\:\:getRGBHashNotation\(\) should return bool but returns string\.$#'
+			identifier: return.type
+			count: 1
+			path: ../src/OutputFormat.php
+
+		-
+			message: '#^Property Sabberworm\\CSS\\OutputFormat\:\:\$bRGBHashNotation \(string\) does not accept bool\.$#'
+			identifier: assign.propertyType
+			count: 1
+			path: ../src/OutputFormat.php
+
+		-
+			message: '#^Property Sabberworm\\CSS\\OutputFormat\:\:\$bRGBHashNotation \(string\) does not accept default value of type true\.$#'
+			identifier: property.defaultValue
+			count: 1
+			path: ../src/OutputFormat.php
+
 		-
 			message: '#^Default value of the parameter \#2 \$bIncludeEnd \(false\) of method Sabberworm\\CSS\\Parsing\\ParserState\:\:consumeUntil\(\) is incompatible with type string\.$#'
 			identifier: parameter.defaultValue
@@ -78,12 +108,24 @@ parameters:
 			count: 1
 			path: ../src/Property/CSSNamespace.php
 
+		-
+			message: '#^Return type \(array\<int, string\>\) of method Sabberworm\\CSS\\Property\\CSSNamespace\:\:atRuleArgs\(\) should be compatible with return type \(string\|null\) of method Sabberworm\\CSS\\Property\\AtRule\:\:atRuleArgs\(\)$#'
+			identifier: method.childReturnType
+			count: 1
+			path: ../src/Property/CSSNamespace.php
+
 		-
 			message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
 			identifier: method.notFound
 			count: 1
 			path: ../src/Property/Charset.php
 
+		-
+			message: '#^Method Sabberworm\\CSS\\Property\\Charset\:\:atRuleArgs\(\) should return string but returns Sabberworm\\CSS\\Value\\CSSString\.$#'
+			identifier: return.type
+			count: 1
+			path: ../src/Property/Charset.php
+
 		-
 			message: '#^PHPDoc tag @param references unknown parameter\: \$oCharset$#'
 			identifier: parameter.notFound
@@ -96,6 +138,12 @@ parameters:
 			count: 1
 			path: ../src/Property/Import.php
 
+		-
+			message: '#^Return type \(array\<int, Sabberworm\\CSS\\Value\\URL\|string\>\) of method Sabberworm\\CSS\\Property\\Import\:\:atRuleArgs\(\) should be compatible with return type \(string\|null\) of method Sabberworm\\CSS\\Property\\AtRule\:\:atRuleArgs\(\)$#'
+			identifier: method.childReturnType
+			count: 1
+			path: ../src/Property/Import.php
+
 		-
 			message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
 			identifier: method.notFound
@@ -150,6 +198,12 @@ parameters:
 			count: 1
 			path: ../src/RuleSet/DeclarationBlock.php
 
+		-
+			message: '#^Argument of an invalid type Sabberworm\\CSS\\Rule\\Rule supplied for foreach, only iterables are supported\.$#'
+			identifier: foreach.nonIterable
+			count: 2
+			path: ../src/RuleSet/RuleSet.php
+
 		-
 			message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:removeLastSemicolon\(\)\.$#'
 			identifier: method.notFound
@@ -234,4 +288,9 @@ parameters:
 			count: 1
 			path: ../src/Value/ValueList.php
 
+		-
+			message: '#^Method Sabberworm\\CSS\\Tests\\Unit\\Value\\ValueTest\:\:provideCssFunctionTemplates\(\) should return array\<string, array\{string, string\}\> but returns array\{calc\: array\{to be parsed\: ''calc\(%%s\);'', expected\: ''calc\(%%s\)''\}, max\: array\{to be parsed\: ''max\(300px, %%s\);'', expected\: ''max\(300px,%%s\)''\}, clamp\: array\{to be parsed\: ''clamp\(2\.19rem, %%s,…'', expected\: ''clamp\(2\.19rem,%%s,2…''\}\}\.$#'
+			identifier: return.type
+			count: 1
+			path: ../tests/Unit/Value/ValueTest.php
 

config/phpstan.neon

@@ -6,7 +6,7 @@ parameters:
     # Don't be overly greedy on machines with more CPU's to be a good neighbor especially on CI
     maximumNumberOfProcesses: 5
 
-  level: 2
+  level: 3
 
   paths:
     - %currentWorkingDirectory%/bin/