Merge pull request #292 from oliverklee/bugfix/rule-value-list-constructor

Fix parent constructor calls in `CalcRuleValueList`

Author: sabberworm

config/phpstan-baseline.neon

@@ -20,8 +20,3 @@ parameters:
 			count: 1
 			path: ../src/Value/CalcFunction.php
 
-		-
-			message: "#^Method Sabberworm\\\\CSS\\\\Value\\\\RuleValueList\\:\\:__construct\\(\\) invoked with 3 parameters, 0\\-2 required\\.$#"
-			count: 1
-			path: ../src/Value/CalcRuleValueList.php
-

src/Value/CalcRuleValueList.php

@@ -11,7 +11,7 @@ class CalcRuleValueList extends RuleValueList
      */
     public function __construct($iLineNo = 0)
     {
-        parent::__construct([], ',', $iLineNo);
+        parent::__construct(',', $iLineNo);
     }
 
     /**

tests/Value/CalcRuleValueListTest.php

@@ -0,0 +1,55 @@
+<?php
+
+namespace Sabberworm\CSS\Tests\Value;
+
+use PHPUnit\Framework\TestCase;
+use Sabberworm\CSS\Value\CalcRuleValueList;
+use Sabberworm\CSS\Value\RuleValueList;
+
+/**
+ * @covers \Sabberworm\CSS\Value\CalcRuleValueList
+ */
+class CalcRuleValueListTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function isRuleValueList()
+    {
+        $subject = new CalcRuleValueList();
+
+        self::assertInstanceOf(RuleValueList::class, $subject);
+    }
+
+    /**
+     * @test
+     */
+    public function getLineNumberByDefaultReturnsZero()
+    {
+        $subject = new CalcRuleValueList();
+
+        self::assertSame(0, $subject->getLineNo());
+    }
+
+    /**
+     * @test
+     */
+    public function getLineNoReturnsLineNumberProvidedToConstructor()
+    {
+        $lineNumber = 42;
+
+        $subject = new CalcRuleValueList($lineNumber);
+
+        self::assertSame($lineNumber, $subject->getLineNo());
+    }
+
+    /**
+     * @test
+     */
+    public function separatorAlwaysIsComma()
+    {
+        $subject = new CalcRuleValueList();
+
+        self::assertSame(',', $subject->getListSeparator());
+    }
+}