Minor fixes and tweaks

Author: sidkshatriya

lib/Sabberworm/CSS/Parser.php

@@ -37,6 +37,14 @@ class Parser {
 	private $aSizeUnits;
 	private $iLineNo;
 
+	/**
+	 * Parser constructor.
+	 * Note that that iLineNo starts from 1 and not 0
+	 *
+	 * @param $sText
+	 * @param Settings|null $oParserSettings
+	 * @param int $iLineNo
+	 */
 	public function __construct($sText, Settings $oParserSettings = null, $iLineNo = 1) {
 		$this->sText = $sText;
 		$this->iCurrentPosition = 0;

lib/Sabberworm/CSS/Parsing/SourceException.php

@@ -5,7 +5,7 @@
 class SourceException extends \Exception {
     private $iLineNo;
     public function __construct($sMessage, $iLineNo = 0) {
-        $this->$iLineNo = $iLineNo;
+        $this->iLineNo = $iLineNo;
         if (!empty($iLineNo)) {
             $sMessage .= " [line no: $iLineNo]";
         }

tests/Sabberworm/CSS/ParserTest.php

@@ -8,7 +8,7 @@
 use Sabberworm\CSS\RuleSet\DeclarationBlock;
 use Sabberworm\CSS\Property\AtRule;
 use Sabberworm\CSS\Value\URL;
-use Sabberworm\CSS\Value\Color;
+use Sabberworm\CSS\Parsing\UnexpectedTokenException;
 
 class ParserTest extends \PHPUnit_Framework_TestCase {
 
@@ -481,7 +481,7 @@ function testLineNumbersParsing() {
 		$aRules = $oDeclBlock->getRules();
 		// Choose the 2nd one
 		$oColor = $aRules[1]->getValue();
-		$this->assertEquals($aRules[1]->getLineNo(), 27);
+		$this->assertEquals(27, $aRules[1]->getLineNo());
 
 		foreach ($oColor->getColor() as $oSize) {
 			$aActualColorLines[] = $oSize->getLineNo();
@@ -493,14 +493,15 @@ function testLineNumbersParsing() {
 	}
 
 	/**
-	 * @expectedException Sabberworm\CSS\Parsing\UnexpectedTokenException
+	 * @expectedException \Sabberworm\CSS\Parsing\UnexpectedTokenException
+	 * Credit: This test by @sabberworm (from https://github.com/sabberworm/PHP-CSS-Parser/pull/105#issuecomment-229643910 )
 	 */
-	public function testUnexpectedTokenExceptionLineNo() {
+	function testUnexpectedTokenExceptionLineNo() {
 		$oParser = new Parser("\ntest: 1;", Settings::create()->beStrict());
 		try {
 			$oParser->parse();
 		} catch (UnexpectedTokenException $e) {
-			$this->assertSame($e->getLineNo(), 2);
+			$this->assertSame(2, $e->getLineNo());
 			throw $e;
 		}
 	}