Skip to content

Commit 74c3604

Browse files
committed
Install the development tools in the CI build the proper way
- install all tools in one step instead of only one tool at a time - install the exact registered version instead of updating (which avoid version-dependent differences between CI and the local environment) - provide the fingerprints of the trusted GPG keys with which the PHARs are signed so that the faked pseudo-interactive "yes" confirmation is not needed anymore
1 parent 0f37bfd commit 74c3604

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,10 @@ jobs:
9191
matrix:
9292
include:
9393
- command: sniffer
94-
tool: phpcs
9594
php-version: 7.4
9695
- command: fixer
97-
tool: php-cs-fixer
9896
php-version: 7.4
9997
- command: stan
100-
tool: phpstan
10198
php-version: 7.4
10299

103100
steps:
@@ -126,8 +123,7 @@ jobs:
126123
127124
- name: Install development tools
128125
run: |
129-
# These workarounds are needed until PHIVE can do installs in a non-interactive way
130-
echo y | phive --no-progress update ${{ matrix.tool }};
126+
phive --no-progress install --trust-gpg-keys BBAB5DF0A0D6672989CF1869E82B2FB314E9906E,A972B9ABB95D0B760B51442231C7E470E2138192,D32680D5957DC7116BE29C14CF1A108D0E7AE720
131127
132128
- name: Run Command
133129
run: composer ci:php:${{ matrix.command }}

0 commit comments

Comments
 (0)