Changes suggested in code review

oliverklee · oliverklee · commit 7fac016e5540 · 2025-02-20T12:11:35.000+01:00
diff --git a/tests/Unit/CSSList/DocumentTest.php b/tests/Unit/CSSList/DocumentTest.php
@@ -215,7 +215,7 @@ public function getAllDeclarationBlocksIgnoresImport(): void
     {
         $subject = new Document();
 
-        $import = new Import(new URL(new CSSString('')), '');
+        $import = new Import(new URL(new CSSString('https://www.example.com/')), '');
         $subject->setContents([$import]);
 
         $result = $subject->getAllDeclarationBlocks();
@@ -230,7 +230,7 @@ public function getAllDeclarationBlocksIgnoresCharset(): void
     {
         $subject = new Document();
 
-        $charset = new Charset(new CSSString(''));
+        $charset = new Charset(new CSSString('UTF-8'));
         $subject->setContents([$charset]);
 
         $result = $subject->getAllDeclarationBlocks();

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ public function getAllDeclarationBlocksIgnoresImport(): void`
`215`	`215`	`{`
`216`	`216`	`$subject = new Document();`
`217`	`217`
`218`		`- $import = new Import(new URL(new CSSString('')), '');`
	`218`	`+ $import = new Import(new URL(new CSSString('https://www.example.com/')), '');`
`219`	`219`	`$subject->setContents([$import]);`
`220`	`220`
`221`	`221`	`$result = $subject->getAllDeclarationBlocks();`
`@@ -230,7 +230,7 @@ public function getAllDeclarationBlocksIgnoresCharset(): void`
`230`	`230`	`{`
`231`	`231`	`$subject = new Document();`
`232`	`232`
`233`		`- $charset = new Charset(new CSSString(''));`
	`233`	`+ $charset = new Charset(new CSSString('UTF-8'));`
`234`	`234`	`$subject->setContents([$charset]);`
`235`	`235`
`236`	`236`	`$result = $subject->getAllDeclarationBlocks();`