Skip to content

Commit f03fa14

Browse files
committed
[TASK] Extend and streamline KeyFrameTest
- use a per-test subject similar to #963 - add a missing `@covers` annotation for the parent class - add tests for the line number Part of #757
1 parent 981464c commit f03fa14

File tree

1 file changed

+29
-10
lines changed

1 file changed

+29
-10
lines changed

tests/Unit/CSSList/KeyFrameTest.php

Lines changed: 29 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,41 +11,60 @@
1111
use Sabberworm\CSS\Renderable;
1212

1313
/**
14+
* @covers \Sabberworm\CSS\CSSList\CSSList
1415
* @covers \Sabberworm\CSS\CSSList\KeyFrame
1516
*/
1617
final class KeyFrameTest extends TestCase
1718
{
1819
/**
19-
* @var KeyFrame
20+
* @test
2021
*/
21-
private $subject;
22+
public function implementsAtRule(): void
23+
{
24+
$subject = new KeyFrame();
25+
26+
self::assertInstanceOf(AtRule::class, $subject);
27+
}
2228

23-
protected function setUp(): void
29+
/**
30+
* @test
31+
*/
32+
public function implementsRenderable(): void
2433
{
25-
$this->subject = new KeyFrame();
34+
$subject = new KeyFrame();
35+
36+
self::assertInstanceOf(Renderable::class, $subject);
2637
}
2738

2839
/**
2940
* @test
3041
*/
31-
public function implementsAtRule(): void
42+
public function implementsCommentable(): void
3243
{
33-
self::assertInstanceOf(AtRule::class, $this->subject);
44+
$subject = new KeyFrame();
45+
46+
self::assertInstanceOf(Commentable::class, $subject);
3447
}
3548

3649
/**
3750
* @test
3851
*/
39-
public function implementsRenderable(): void
52+
public function getLineNoByDefaultReturnsZero(): void
4053
{
41-
self::assertInstanceOf(Renderable::class, $this->subject);
54+
$subject = new KeyFrame();
55+
56+
self::assertSame(0, $subject->getLineNo());
4257
}
4358

4459
/**
4560
* @test
4661
*/
47-
public function implementsCommentable(): void
62+
public function getLineNoReturnsLineNumberProvidedToConstructor(): void
4863
{
49-
self::assertInstanceOf(Commentable::class, $this->subject);
64+
$lineNumber = 42;
65+
66+
$subject = new KeyFrame($lineNumber);
67+
68+
self::assertSame($lineNumber, $subject->getLineNo());
5069
}
5170
}

0 commit comments

Comments
 (0)