Skip to content

Commit f587f1a

Browse files
oliverkleeoliverklee
authored
[TASK] Avoid Hungarian notation in a testcase (#684)
1 parent b0d6c4e commit f587f1a

File tree

1 file changed

+35
-35
lines changed

1 file changed

+35
-35
lines changed

‎tests/RuleSet/LenientParsingTest.php

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,23 @@ public function faultToleranceOff(): void
2929
{
3030
$this->expectException(UnexpectedTokenException::class);
3131

32-
$sFile = __DIR__ . '/../fixtures/-fault-tolerance.css';
33-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->beStrict());
34-
$oParser->parse();
32+
$pathToFile = __DIR__ . '/../fixtures/-fault-tolerance.css';
33+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->beStrict());
34+
$parser->parse();
3535
}
3636

3737
/**
3838
* @test
3939
*/
4040
public function faultToleranceOn(): void
4141
{
42-
$sFile = __DIR__ . '/../fixtures/-fault-tolerance.css';
43-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->withLenientParsing(true));
44-
$oResult = $oParser->parse();
42+
$pathToFile = __DIR__ . '/../fixtures/-fault-tolerance.css';
43+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->withLenientParsing(true));
44+
$result = $parser->parse();
4545
self::assertSame(
4646
'.test1 {}' . "\n" . '.test2 {hello: 2.2;hello: 2000000000000.2;}' . "\n" . '#test {}' . "\n"
4747
. '#test2 {help: none;}',
48-
$oResult->render()
48+
$result->render()
4949
);
5050
}
5151

@@ -56,9 +56,9 @@ public function endToken(): void
5656
{
5757
$this->expectException(UnexpectedTokenException::class);
5858

59-
$sFile = __DIR__ . '/../fixtures/-end-token.css';
60-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->beStrict());
61-
$oParser->parse();
59+
$pathToFile = __DIR__ . '/../fixtures/-end-token.css';
60+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->beStrict());
61+
$parser->parse();
6262
}
6363

6464
/**
@@ -68,33 +68,33 @@ public function endToken2(): void
6868
{
6969
$this->expectException(UnexpectedTokenException::class);
7070

71-
$sFile = __DIR__ . '/../fixtures/-end-token-2.css';
72-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->beStrict());
73-
$oParser->parse();
71+
$pathToFile = __DIR__ . '/../fixtures/-end-token-2.css';
72+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->beStrict());
73+
$parser->parse();
7474
}
7575

7676
/**
7777
* @test
7878
*/
7979
public function endTokenPositive(): void
8080
{
81-
$sFile = __DIR__ . '/../fixtures/-end-token.css';
82-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->withLenientParsing(true));
83-
$oResult = $oParser->parse();
84-
self::assertSame('', $oResult->render());
81+
$pathToFile = __DIR__ . '/../fixtures/-end-token.css';
82+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->withLenientParsing(true));
83+
$result = $parser->parse();
84+
self::assertSame('', $result->render());
8585
}
8686

8787
/**
8888
* @test
8989
*/
9090
public function endToken2Positive(): void
9191
{
92-
$sFile = __DIR__ . '/../fixtures/-end-token-2.css';
93-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->withLenientParsing(true));
94-
$oResult = $oParser->parse();
92+
$pathToFile = __DIR__ . '/../fixtures/-end-token-2.css';
93+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->withLenientParsing(true));
94+
$result = $parser->parse();
9595
self::assertSame(
9696
'#home .bg-layout {background-image: url("/bundles/main/img/bg1.png?5");}',
97-
$oResult->render()
97+
$result->render()
9898
);
9999
}
100100

@@ -104,13 +104,13 @@ public function endToken2Positive(): void
104104
public function localeTrap(): void
105105
{
106106
\setlocale(LC_ALL, 'pt_PT', 'no');
107-
$sFile = __DIR__ . '/../fixtures/-fault-tolerance.css';
108-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->withLenientParsing(true));
109-
$oResult = $oParser->parse();
107+
$pathToFile = __DIR__ . '/../fixtures/-fault-tolerance.css';
108+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->withLenientParsing(true));
109+
$result = $parser->parse();
110110
self::assertSame(
111111
'.test1 {}' . "\n" . '.test2 {hello: 2.2;hello: 2000000000000.2;}' . "\n" . '#test {}' . "\n"
112112
. '#test2 {help: none;}',
113-
$oResult->render()
113+
$result->render()
114114
);
115115
}
116116

@@ -119,17 +119,17 @@ public function localeTrap(): void
119119
*/
120120
public function caseInsensitivity(): void
121121
{
122-
$sFile = __DIR__ . '/../fixtures/case-insensitivity.css';
123-
$oParser = new Parser(\file_get_contents($sFile));
124-
$oResult = $oParser->parse();
122+
$pathToFile = __DIR__ . '/../fixtures/case-insensitivity.css';
123+
$parser = new Parser(\file_get_contents($pathToFile));
124+
$result = $parser->parse();
125125

126126
self::assertSame(
127127
'@charset "utf-8";' . "\n"
128128
. '@import url("test.css");'
129129
. "\n@media screen {}"
130130
. "\n#myid {case: insensitive !important;frequency: 30Hz;font-size: 1em;color: #ff0;"
131131
. 'color: hsl(40,40%,30%);font-family: Arial;}',
132-
$oResult->render()
132+
$result->render()
133133
);
134134
}
135135

@@ -138,9 +138,9 @@ public function caseInsensitivity(): void
138138
*/
139139
public function cssWithInvalidColorStillGetsParsedAsDocument(): void
140140
{
141-
$sFile = __DIR__ . '/../fixtures/invalid-color.css';
142-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->withLenientParsing(true));
143-
$result = $oParser->parse();
141+
$pathToFile = __DIR__ . '/../fixtures/invalid-color.css';
142+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->withLenientParsing(true));
143+
$result = $parser->parse();
144144

145145
self::assertInstanceOf(Document::class, $result);
146146
}
@@ -152,8 +152,8 @@ public function invalidColorStrict(): void
152152
{
153153
$this->expectException(UnexpectedTokenException::class);
154154

155-
$sFile = __DIR__ . '/../fixtures/invalid-color.css';
156-
$oParser = new Parser(\file_get_contents($sFile), Settings::create()->beStrict());
157-
$oParser->parse();
155+
$pathToFile = __DIR__ . '/../fixtures/invalid-color.css';
156+
$parser = new Parser(\file_get_contents($pathToFile), Settings::create()->beStrict());
157+
$parser->parse();
158158
}
159159
}

0 commit comments

Comments
 (0)