Make compute-sanitizer not report API errors as errors #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
P0
|
/ok to test 1d32e14 |
|
|
cc @carterbox for vis |
kkraus14
approved these changes
Jun 7, 2025
|
Since the CI was green and the last commit was largely innocent, let me admin-merge and test it in the other PR. Thanks, Keith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We rely on driver/runtime to report API errors to us for decision making and input checking (#685). If the compute-sanitizer keeps treating API errors as real errors, we end up skipping the majority of the test suite. Before the sanitizer can suppress errors on a per-API basis, we turn
--report-api-errorsoff globally.Checklist