Skip to content

Naming conventions across build targets #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

gwleuverink
Copy link

@gwleuverink gwleuverink commented Jan 17, 2025

This change normalises naming conventions across build targets.

Goes along with commit NativePHP/electron@b0b9c34 in PR NativePHP/electron#153

@gwleuverink gwleuverink changed the title remove mac x86 naming deviation Naming conventions across build targets Jan 17, 2025
Copy link
Member

@SRWieZ SRWieZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will merged it at the same time we merge your build refactor.

Approved

@simonhamp simonhamp merged commit 1b5205b into NativePHP:main Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants