Skip to content

Update dependencies #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Update dependencies #4

merged 4 commits into from
Jan 22, 2019

Conversation

pavlospt
Copy link
Contributor

  • Bump AGP version (3.3.0)
  • Bump Kotlin version (1.3.11)
  • Bump Gradle version (5.1.1)

Made some required changes in RootCoveragePlugin to accomodate for the update to 5.1.1.

@Rolf-Smit
Copy link
Contributor

I hate to tell you but... I think we did the same work:

5822f49

My commit also contains a bug fix that was skipping some output:

            // Android Build Tools Plugin 3.2
            list.add("outputs/code-coverage/connected/*coverage.ec")

            // Android Build Tools Plugin 3.3+
            list.add("outputs/code_coverage/*/connected/*coverage.ec")

But since I don't want your contribution to be tossed aside. I think the best approach is to merge your work and apply additional fixes on top of it. Which is exactly what I'm going to do.

@Rolf-Smit Rolf-Smit merged commit 527d507 into NeoTech-Software:master Jan 22, 2019
@pavlospt pavlospt deleted the update_dependencies branch January 22, 2019 15:29
@pavlospt
Copy link
Contributor Author

Ohh did not notice you had a branch that you were working on, my bad! Please feel free to apply any changes you may find suitable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants