Skip to content

Commit 167e40a

Browse files
danbevggerganov
authored andcommitted
llama : add early return for empty range (ggml-org#8327)
* llama : add early return for empty range This commit adds an early return to the llama_kv_cache_seq_add and llama_kv_cache_seq_div functions. The motivation for adding this is to avoid looping over the cache when the range is empty. I ran into this when using the self-extend feature in main.cpp. Signed-off-by: Daniel Bevenius <[email protected]> * llama : add static_cast to fix CI warning/error This commit attempts to fix the following warning/error: ```console src/llama.cpp:7271:31: error: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare] 7271 | if (i < hparams.n_layer_dense_lead) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This can be reproduced locally by setting -Wsign-compare in the Makefile. Signed-off-by: Daniel Bevenius <[email protected]> * squash! llama : add early return for empty range Remove the setting of cache.head to 0 when the range is empty. Signed-off-by: Daniel Bevenius <[email protected]> * Update src/llama.cpp --------- Signed-off-by: Daniel Bevenius <[email protected]> Co-authored-by: Georgi Gerganov <[email protected]>
1 parent c50dcbd commit 167e40a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

llama.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3299,6 +3299,8 @@ static void llama_kv_cache_seq_add(
32993299

33003300
if (p0 < 0) p0 = 0;
33013301
if (p1 < 0) p1 = std::numeric_limits<llama_pos>::max();
3302+
// If there is no range then return early to avoid looping over the cache.
3303+
if (p0 == p1) return;
33023304

33033305
if (cache.recurrent) {
33043306
// for Mamba-like models, only the pos needs to be shifted
@@ -3343,6 +3345,8 @@ static void llama_kv_cache_seq_div(
33433345
int d) {
33443346
if (p0 < 0) p0 = 0;
33453347
if (p1 < 0) p1 = std::numeric_limits<llama_pos>::max();
3348+
// If there is no range then return early to avoid looping over the cache.
3349+
if (p0 == p1) return;
33463350

33473351
if (cache.recurrent) {
33483352
// for Mamba-like models, only the pos needs to be changed

0 commit comments

Comments
 (0)