Other switches might set changed as true. Use extraStrings size

brenoguim · brenoguim · commit ca23391ed32f · 2023-03-04T13:10:16.000-03:00
diff --git a/src/patchelf.cc b/src/patchelf.cc
@@ -2134,7 +2134,7 @@ void ElfFile<ElfFileParamNames>::renameDynamicSymbols(const std::unordered_map<s
         }
     }
 
-    if (changed)
+    if (!extraStrings.empty())
     {
         auto newStrTabSize = strTab.size() + extraStrings.size();
         auto& newSec = replaceSection(".dynstr", newStrTabSize);

Original file line number	Diff line number	Diff line change
`@@ -2134,7 +2134,7 @@ void ElfFile<ElfFileParamNames>::renameDynamicSymbols(const std::unordered_map<s`
`2134`	`2134`	`}`
`2135`	`2135`	`}`
`2136`	`2136`
`2137`		`- if (changed)`
	`2137`	`+ if (!extraStrings.empty())`
`2138`	`2138`	`{`
`2139`	`2139`	`auto newStrTabSize = strTab.size() + extraStrings.size();`
`2140`	`2140`	`auto& newSec = replaceSection(".dynstr", newStrTabSize);`