Skip to content

Use absoloute paths to linker scripts #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

klemensn
Copy link
Contributor

@klemensn klemensn commented Dec 6, 2021

As is common with autotools enabled software, building and testing
happens outside the source directory.

The introduction of contiguous-note-sections test in 0.13 broke this
by assuming linker scripts to exist in the current working directory.

Point at the absoloute source directory explicitly to unbreak linking in
such build environments.

Spotted on OpenBSD where source and build assets are commonly
separated iff possible.

As is common with autotools enabled software, building and testing
happens outside the source directory.

The introduction of `contiguous-note-sections` test in 0.13 broke this
by assuming linker scripts to exist in the current working directory.

Point at the absoloute source directory explicitly to unbreak linking in
such build environments.

Spotted on OpenBSD where source and build assets are commonly separated
iff possible.
@klemensn
Copy link
Contributor Author

klemensn commented Dec 6, 2021

With the build fixed, running tests now only shows endianness not being
out-of-tree aware:

$ cat endianness.sh.log
cp: endianness/ppc64/main: No such file or directory
cp: endianness/ppc64/libtest.so: No such file or directory
FAIL endianness.sh (exit status: 1)

I'll give this one a try as well when time allows.

The submitted fix lets me run tests in the first place, so that's a start.

Maybe CI infrastructure can be changed to build out-of-tree as well to catch
such behaviour?

@Mic92 Mic92 mentioned this pull request Dec 7, 2021
@Mic92 Mic92 merged commit ce99c93 into NixOS:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants