Merge pull request #182 from OWASP/fix-k8s-test

Fix for minikube tests

Author: commjoen

.github/workflows/minikube-k8s-test.yml

@@ -23,14 +23,14 @@ jobs:
       - name: Start minikube
         uses: medyagh/setup-minikube@master
         with:
-          minikube-version: 1.27.0
+          minikube-version: 1.29.0
           driver: docker
           kubernetes-version: v1.23.12
       - name: test script
         run: |
           eval $(minikube docker-env)
           ./build-an-deploy.sh
-          while [[ $(kubectl get pods -l app=wrongsecrets-balancer -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != "True" ]]; do echo "waiting for wrongsecrets-balancer" && sleep 2; done
+          while [[ $(kubectl get pods -l app=wrongsecrets-balancer -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != *"True"* ]]; do echo "waiting for wrongsecrets-balancer" && sleep 2; done
           kubectl logs deployments/wrongsecrets-balancer -f >> pod.log &
           echo "port forwarding"
           kubectl port-forward service/wrongsecrets-balancer 3000:3000 &

helm/wrongsecrets-ctf-party/values.yaml

@@ -35,7 +35,7 @@ balancer:
     cookieParserSecret: null
   repository: jeroenwillemsen/wrongsecrets-balancer
   tag: 1.7aws
-  # -- Number of replicas of the wrongsecrets-balancer deployment
+  # -- Number of replicas of the wrongsecrets-balancer deployment. Changing this in a commit? PLEASE UPDATE THE GITHUB WORKLFOWS THEN!(NUMBER OF "TRUE")
   replicas: 4
   service:
     # -- Kubernetes service type

readme.md

@@ -110,7 +110,7 @@ For minikube, run:
 
 ```shell
 
-minikube start  --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico
+minikube start  --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico --driver=docker
 eval $(minikube docker-env)
 ./build-an-deploy-container.sh
 kubectl port-forward service/wrongsecrets-balancer 3000:3000
@@ -129,7 +129,7 @@ kubectl top pods
 
 ```shell
 
-minikube start  --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico
+minikube start  --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico --driver=docker
 eval $(minikube docker-env)
 ./build-an-deploy.sh
 kubectl port-forward service/wrongsecrets-balancer 3000:3000