fix for key assignment

Author: commjoen

wrongsecrets-balancer/src/teams/teams.js

@@ -7,6 +7,7 @@ const Joi = require('@hapi/joi');
 const expressJoiValidation = require('express-joi-validation');
 const promClient = require('prom-client');
 const accessPassword = process.env.REACT_APP_ACCESS_PASSWORD;
+const hmac_key = process.env.REACT_APP_CREATE_TEAM_HMAC_KEY || 'hardcodedkey';
 
 const validator = expressJoiValidation.createValidator();
 const k8sEnv = process.env.K8S_ENV || 'k8s';
@@ -94,10 +95,6 @@ async function validateHMAC(req, res, next) {
   try {
     const { team } = req.params;
     const { hmacvalue } = req.body;
-    var hmac_key = process.env.REACT_APP_CREATE_TEAM_HMAC_KEY;
-    if (hmac_key === undefined || hmac_key === '') {
-      hmac_key = 'hardcodedkey';
-    }
     const validationValue = crypto
       .createHmac('sha256', hmac_key)
       .update(`${team}`, 'utf-8')